Race condition in initializing message manager for window.opened <iframe mozbrowser>s causes test_browserElement_oop_OpenNamed.html (from bug 780546) to fail intermittently

RESOLVED FIXED in mozilla17

Status

()

Core
DOM
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: emorley, Assigned: Justin Lebar (not reading bugmail))

Tracking

({intermittent-failure})

Trunk
mozilla17
x86_64
Mac OS X
intermittent-failure
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Rev4 MacOSX Lion 10.7 mozilla-inbound opt test mochitests-2/5 on 2012-08-06 10:01:34 PDT for push 633d8533e7cf

slave: talos-r4-lion-055

https://tbpl.mozilla.org/php/getParsedLog.php?id=14161964&tree=Mozilla-Inbound

{
1138 INFO TEST-START | /tests/dom/browser-element/mochitest/test_browserElement_oop_OpenNamed.html
creating 1!
[TabChild] SHOW (w,h)= (0, 0)
loading http://mochi.test:8888/tests/dom/browser-element/mochitest/file_browserElement_OpenNamed.html, 1
creating 1!
1139 INFO TEST-PASS | /tests/dom/browser-element/mochitest/test_browserElement_oop_OpenNamed.html | Should get just one popup. - false should equal false
[TabChild] SHOW (w,h)= (0, 0)
1140 INFO TEST-PASS | /tests/dom/browser-element/mochitest/test_browserElement_oop_OpenNamed.html | Got openwindow event before showmodalprompt event.
1141 INFO TEST-PASS | /tests/dom/browser-element/mochitest/test_browserElement_oop_OpenNamed.html | undefined - success: loaded should equal success: loaded
1142 ERROR TEST-UNEXPECTED-FAIL | /tests/dom/browser-element/mochitest/test_browserElement_oop_OpenNamed.html | an unexpected uncaught JS exception reported through window.onerror - NS_ERROR_NOT_INITIALIZED: Component returned failure code: 0xc1f30001 (NS_ERROR_NOT_INITIALIZED) [nsIChromeFrameMessageManager.sendAsyncMessage] at resource:///components/BrowserElementParent.js:250
loading http://mochi.test:8888/tests/dom/browser-element/mochitest/file_browserElement_OpenNamed.html?test2, 1
1143 INFO TEST-END | /tests/dom/browser-element/mochitest/test_browserElement_oop_OpenNamed.html | finished in 98ms
}
Comment hidden (Treeherder Robot)
(Assignee)

Updated

5 years ago
Summary: Intermittent test_browserElement_oop_OpenNamed.html | uncaught JS exception - Component returned failure code: 0xc1f30001 (NS_ERROR_NOT_INITIALIZED) [nsIChromeFrameMessageManager.sendAsyncMessage] at BrowserElementParent.js:250 → Race condition in initializing message manager for window.opened <iframe mozbrowser>s causes the test in bug 780546 to fail intermittently
(Assignee)

Comment 2

5 years ago
Created attachment 650346 [details] [diff] [review]
Patch, v1

An explanation of what's going on is in the patch.
Attachment #650346 - Flags: review?(bugs)
(Assignee)

Comment 3

5 years ago
> An explanation of what's going on is in the patch.

Erm, apparently that got truncated.

> Calling show() causes EnsureMessageManager() to SetCallbackData() on the message manager.  If we 
> don't do this, then the message manager will throw when we try to send a message.
(Assignee)

Updated

5 years ago
Blocks: 780351
(Reporter)

Comment 4

5 years ago
Please leave at a minimum the test name in the summary, or it breaks TBPL starring.
(Reporter)

Comment 5

5 years ago
And thank you for looking into this :-)
(Assignee)

Updated

5 years ago
Summary: Race condition in initializing message manager for window.opened <iframe mozbrowser>s causes the test in bug 780546 to fail intermittently → Race condition in initializing message manager for window.opened <iframe mozbrowser>s causes test_browserElement_oop_OpenNamed.html (from bug 780546) to fail intermittently
(Assignee)

Comment 6

5 years ago
(In reply to Ed Morley [:edmorley] from comment #4)
> Please leave at a minimum the test name in the summary, or it breaks TBPL
> starring.

Is the basename sufficient, or do I need the full path?
(Reporter)

Comment 7

5 years ago
(In reply to Justin Lebar [:jlebar] from comment #6)
> Is the basename sufficient, or do I need the full path?

Just the basename is fine :-)
(Assignee)

Comment 8

5 years ago
> Calling show() causes EnsureMessageManager() to SetCallbackData() on the message manager.  If we 
> don't do this, then the message manager will throw when we try to send a message.

See also bug 780546 comment 9; the only problem with that analysis was that I was looking at the wrong remote-browser-frame-shown call.  :)
(Assignee)

Updated

5 years ago
Assignee: nobody → justin.lebar+bug
Attachment #650346 - Flags: review?(bugs) → review+
(Reporter)

Comment 9

5 years ago
https://hg.mozilla.org/mozilla-central/rev/c5779872c0f0
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
Keywords: intermittent-failure
Whiteboard: [orange]
Component: DOM: Mozilla Extensions → DOM
Product: Core → Core
You need to log in before you can comment on or make changes to this bug.