Last Comment Bug 780761 - Race condition in initializing message manager for window.opened <iframe mozbrowser>s causes test_browserElement_oop_OpenNamed.html (from bug 780546) to fail intermittently
: Race condition in initializing message manager for window.opened <iframe mozb...
Status: RESOLVED FIXED
: intermittent-failure
Product: Core
Classification: Components
Component: DOM (show other bugs)
: Trunk
: x86_64 Mac OS X
: -- normal (vote)
: mozilla17
Assigned To: Justin Lebar (not reading bugmail)
:
: Andrew Overholt [:overholt]
Mentors:
Depends on:
Blocks: 438871 780351 780546
  Show dependency treegraph
 
Reported: 2012-08-06 16:01 PDT by Ed Morley [:emorley]
Modified: 2013-04-04 13:53 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch, v1 (997 bytes, patch)
2012-08-08 15:48 PDT, Justin Lebar (not reading bugmail)
bugs: review+
Details | Diff | Splinter Review

Description Ed Morley [:emorley] 2012-08-06 16:01:18 PDT
Rev4 MacOSX Lion 10.7 mozilla-inbound opt test mochitests-2/5 on 2012-08-06 10:01:34 PDT for push 633d8533e7cf

slave: talos-r4-lion-055

https://tbpl.mozilla.org/php/getParsedLog.php?id=14161964&tree=Mozilla-Inbound

{
1138 INFO TEST-START | /tests/dom/browser-element/mochitest/test_browserElement_oop_OpenNamed.html
creating 1!
[TabChild] SHOW (w,h)= (0, 0)
loading http://mochi.test:8888/tests/dom/browser-element/mochitest/file_browserElement_OpenNamed.html, 1
creating 1!
1139 INFO TEST-PASS | /tests/dom/browser-element/mochitest/test_browserElement_oop_OpenNamed.html | Should get just one popup. - false should equal false
[TabChild] SHOW (w,h)= (0, 0)
1140 INFO TEST-PASS | /tests/dom/browser-element/mochitest/test_browserElement_oop_OpenNamed.html | Got openwindow event before showmodalprompt event.
1141 INFO TEST-PASS | /tests/dom/browser-element/mochitest/test_browserElement_oop_OpenNamed.html | undefined - success: loaded should equal success: loaded
1142 ERROR TEST-UNEXPECTED-FAIL | /tests/dom/browser-element/mochitest/test_browserElement_oop_OpenNamed.html | an unexpected uncaught JS exception reported through window.onerror - NS_ERROR_NOT_INITIALIZED: Component returned failure code: 0xc1f30001 (NS_ERROR_NOT_INITIALIZED) [nsIChromeFrameMessageManager.sendAsyncMessage] at resource:///components/BrowserElementParent.js:250
loading http://mochi.test:8888/tests/dom/browser-element/mochitest/file_browserElement_OpenNamed.html?test2, 1
1143 INFO TEST-END | /tests/dom/browser-element/mochitest/test_browserElement_oop_OpenNamed.html | finished in 98ms
}
Comment 1 Treeherder Robot 2012-08-07 07:38:30 PDT
edmorley
https://tbpl.mozilla.org/php/getParsedLog.php?id=14189594&tree=Firefox
Rev3 Fedora 12 mozilla-central pgo test mochitests-2/5 on 2012-08-07 07:10:09
slave: talos-r3-fed-037

1139 ERROR TEST-UNEXPECTED-FAIL | /tests/dom/browser-element/mochitest/test_browserElement_oop_OpenNamed.html | an unexpected uncaught JS exception reported through window.onerror - NS_ERROR_NOT_INITIALIZED: Component returned failure code: 0xc1f30001 (NS_ERROR_NOT_INITIALIZED) [nsIChromeFrameMessageManager.sendAsyncMessage] at resource:///components/BrowserElementParent.js:250
Comment 2 Justin Lebar (not reading bugmail) 2012-08-08 15:48:10 PDT
Created attachment 650346 [details] [diff] [review]
Patch, v1

An explanation of what's going on is in the patch.
Comment 3 Justin Lebar (not reading bugmail) 2012-08-08 15:49:02 PDT
> An explanation of what's going on is in the patch.

Erm, apparently that got truncated.

> Calling show() causes EnsureMessageManager() to SetCallbackData() on the message manager.  If we 
> don't do this, then the message manager will throw when we try to send a message.
Comment 4 Ed Morley [:emorley] 2012-08-08 16:06:01 PDT
Please leave at a minimum the test name in the summary, or it breaks TBPL starring.
Comment 5 Ed Morley [:emorley] 2012-08-08 16:06:28 PDT
And thank you for looking into this :-)
Comment 6 Justin Lebar (not reading bugmail) 2012-08-08 20:00:39 PDT
(In reply to Ed Morley [:edmorley] from comment #4)
> Please leave at a minimum the test name in the summary, or it breaks TBPL
> starring.

Is the basename sufficient, or do I need the full path?
Comment 7 Ed Morley [:emorley] 2012-08-09 02:56:44 PDT
(In reply to Justin Lebar [:jlebar] from comment #6)
> Is the basename sufficient, or do I need the full path?

Just the basename is fine :-)
Comment 8 Justin Lebar (not reading bugmail) 2012-08-09 07:56:29 PDT
> Calling show() causes EnsureMessageManager() to SetCallbackData() on the message manager.  If we 
> don't do this, then the message manager will throw when we try to send a message.

See also bug 780546 comment 9; the only problem with that analysis was that I was looking at the wrong remote-browser-frame-shown call.  :)
Comment 9 Ed Morley [:emorley] 2012-08-14 06:01:29 PDT
https://hg.mozilla.org/mozilla-central/rev/c5779872c0f0

Note You need to log in before you can comment on or make changes to this bug.