780761 - Race condition in initializing message manager for window.opened <iframe mozbrowser>s causes test_browserElement_oop_OpenNamed.html (from bug 780546) to fail intermittently

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Ed Morley [:emorley]]

Rev4 MacOSX Lion 10.7 mozilla-inbound opt test mochitests-2/5 on 2012-08-06 10:01:34 PDT for push 633d8533e7cf

slave: talos-r4-lion-055

https://tbpl.mozilla.org/php/getParsedLog.php?id=14161964&tree=Mozilla-Inbound

{
1138 INFO TEST-START | /tests/dom/browser-element/mochitest/test_browserElement_oop_OpenNamed.html
creating 1!
[TabChild] SHOW (w,h)= (0, 0)
loading http://mochi.test:8888/tests/dom/browser-element/mochitest/file_browserElement_OpenNamed.html, 1
creating 1!
1139 INFO TEST-PASS | /tests/dom/browser-element/mochitest/test_browserElement_oop_OpenNamed.html | Should get just one popup. - false should equal false
[TabChild] SHOW (w,h)= (0, 0)
1140 INFO TEST-PASS | /tests/dom/browser-element/mochitest/test_browserElement_oop_OpenNamed.html | Got openwindow event before showmodalprompt event.
1141 INFO TEST-PASS | /tests/dom/browser-element/mochitest/test_browserElement_oop_OpenNamed.html | undefined - success: loaded should equal success: loaded
1142 ERROR TEST-UNEXPECTED-FAIL | /tests/dom/browser-element/mochitest/test_browserElement_oop_OpenNamed.html | an unexpected uncaught JS exception reported through window.onerror - NS_ERROR_NOT_INITIALIZED: Component returned failure code: 0xc1f30001 (NS_ERROR_NOT_INITIALIZED) [nsIChromeFrameMessageManager.sendAsyncMessage] at resource:///components/BrowserElementParent.js:250
loading http://mochi.test:8888/tests/dom/browser-element/mochitest/file_browserElement_OpenNamed.html?test2, 1
1143 INFO TEST-END | /tests/dom/browser-element/mochitest/test_browserElement_oop_OpenNamed.html | finished in 98ms
}

Comment 1

[Legacy TBPL/Treeherder Robot]

edmorley
https://tbpl.mozilla.org/php/getParsedLog.php?id=14189594&tree=Firefox
Rev3 Fedora 12 mozilla-central pgo test mochitests-2/5 on 2012-08-07 07:10:09
slave: talos-r3-fed-037

1139 ERROR TEST-UNEXPECTED-FAIL | /tests/dom/browser-element/mochitest/test_browserElement_oop_OpenNamed.html | an unexpected uncaught JS exception reported through window.onerror - NS_ERROR_NOT_INITIALIZED: Component returned failure code: 0xc1f30001 (NS_ERROR_NOT_INITIALIZED) [nsIChromeFrameMessageManager.sendAsyncMessage] at resource:///components/BrowserElementParent.js:250

Comment 2

[Justin Lebar (not reading bugmail)]

Attachment: Patch, v1

An explanation of what's going on is in the patch.

Comment 3

[Justin Lebar (not reading bugmail)]

> An explanation of what's going on is in the patch.

Erm, apparently that got truncated.

> Calling show() causes EnsureMessageManager() to SetCallbackData() on the message manager.  If we 
> don't do this, then the message manager will throw when we try to send a message.

Comment 4

[Ed Morley [:emorley]]

Please leave at a minimum the test name in the summary, or it breaks TBPL starring.

Comment 5

[Ed Morley [:emorley]]

And thank you for looking into this :-)

Comment 6

[Justin Lebar (not reading bugmail)]

(In reply to Ed Morley [:edmorley] from comment #4)
> Please leave at a minimum the test name in the summary, or it breaks TBPL
> starring.

Is the basename sufficient, or do I need the full path?

Comment 7

[Ed Morley [:emorley]]

(In reply to Justin Lebar [:jlebar] from comment #6)
> Is the basename sufficient, or do I need the full path?

Just the basename is fine :-)

Comment 8

[Justin Lebar (not reading bugmail)]

> Calling show() causes EnsureMessageManager() to SetCallbackData() on the message manager.  If we 
> don't do this, then the message manager will throw when we try to send a message.

See also bug 780546 comment 9; the only problem with that analysis was that I was looking at the wrong remote-browser-frame-shown call.  :)

Comment 9

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/c5779872c0f0