780824 - Pymake may use special targets as default

Status: RESOLVED WONTFIX

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

In memory/jemalloc/src/Makefile.in, the default rule pymake decides to use is... .SUFFIXES.

$ cat > foo.mk <<EOF
.SUFFIXES:
	@echo foo

bar:
	@echo bar
$ make -f foo.mk
bar
$ python build/pymake/make.py -f foo.mk
foo

I think all .something rules are ignored by GNU make. (adding a .FOO rule doesn't make it the default, while obviously, .FOO has no meaning to GNU make)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Ignore all targets starting with a dot in pymake

Comment 2

[Mike Hommey [:glandium]]

Attachment: Ignore all targets starting with a dot in pymake

With a test.

Comment 3

[Mike Hommey [:glandium]]

In fact, without this patch and without the patch for bug 777379, the default rule for most directories is .PRECIOUS.

Comment 4

[(not currently active) Ted Mielczarek]

Comment on attachment 649552 [details] [diff] [review]
Ignore all targets starting with a dot in pymake

Review of attachment 649552 [details] [diff] [review]:
-----------------------------------------------------------------

From browsing the gmake source, it looks like the actual rule here is "starts with a . and does not contain a / or \ ". r=me if we match the (admittedly insane) gmake behavior.

Comment 5

[Chris Cooper [:coop] (he/him)]

Mass close of pymake-related bugs.