780857 - Enable the dom.experimental forms by default in B2G

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Mounir Lamouri (:mounir)]

Follow-up from bug 780080, we should enable that pref to 'number' and soon 'date' will be enabled in B2G.

You will have to update b2g/chrome/content/forms.js and remove the special cases.

Comment 1

[Raphael Catolino (:raphc)]

Attachment: patch

Comment 2

[Mounir Lamouri (:mounir)]

Comment on attachment 650014 [details] [diff] [review]
patch

Review of attachment 650014 [details] [diff] [review]:
-----------------------------------------------------------------

r=me

Please attach a patch ready to be pushed (with author info and commit message).

::: b2g/app/b2g.js
@@ +472,5 @@
>  
>  // Disable window.showModalDialog
>  pref("dom.disable_window_showModalDialog", true);
>  
> +// Enable implemented new html forms

implemented or experimental? ;)

Comment 3

[Raphael Catolino (:raphc)]

Attachment: patch

Comment 4

[Raphael Catolino (:raphc)]

(In reply to Mounir Lamouri (:mounir) from comment #2)
> Comment on attachment 650014 [details] [diff] [review]
> patch
> 
> Review of attachment 650014 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> r=me
> 
> Please attach a patch ready to be pushed (with author info and commit
> message).
I added r=you, was there anything else missing? (author/commit message??)
> 
> ::: b2g/app/b2g.js
> @@ +472,5 @@
> >  
> >  // Disable window.showModalDialog
> >  pref("dom.disable_window_showModalDialog", true);
> >  
> > +// Enable implemented new html forms
> 
> implemented or experimental? ;)
I was using implemented to note that not all experimental forms were ready yet. Doesn't really mater either way. They should be soon :)

Comment 5

[Mounir Lamouri (:mounir)]

Raphael, I think you will have to update your patch. It's likely bitrotted by the landing of bug 780080.

Comment 6

[Raphael Catolino (:raphc)]

Attachment: patch

Comment 7

[Mounir Lamouri (:mounir)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/38190b5c8d29

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/38190b5c8d29