Closed Bug 780857 Opened 8 years ago Closed 8 years ago

Enable the dom.experimental forms by default in B2G

Categories

(Firefox OS Graveyard :: General, defect)

defect
Not set
normal

Tracking

(blocking-basecamp:-)

RESOLVED FIXED
blocking-basecamp -

People

(Reporter: mounir, Assigned: raphc)

References

Details

Attachments

(1 file, 2 obsolete files)

Follow-up from bug 780080, we should enable that pref to 'number' and soon 'date' will be enabled in B2G.

You will have to update b2g/chrome/content/forms.js and remove the special cases.
blocking-basecamp: --- → ?
Attached patch patch (obsolete) — Splinter Review
Attachment #650014 - Flags: review?(mounir)
Comment on attachment 650014 [details] [diff] [review]
patch

Review of attachment 650014 [details] [diff] [review]:
-----------------------------------------------------------------

r=me

Please attach a patch ready to be pushed (with author info and commit message).

::: b2g/app/b2g.js
@@ +472,5 @@
>  
>  // Disable window.showModalDialog
>  pref("dom.disable_window_showModalDialog", true);
>  
> +// Enable implemented new html forms

implemented or experimental? ;)
Attachment #650014 - Flags: review?(mounir) → review+
Attached patch patch (obsolete) — Splinter Review
Attachment #650014 - Attachment is obsolete: true
Attachment #650017 - Flags: review+
(In reply to Mounir Lamouri (:mounir) from comment #2)
> Comment on attachment 650014 [details] [diff] [review]
> patch
> 
> Review of attachment 650014 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> r=me
> 
> Please attach a patch ready to be pushed (with author info and commit
> message).
I added r=you, was there anything else missing? (author/commit message??)
> 
> ::: b2g/app/b2g.js
> @@ +472,5 @@
> >  
> >  // Disable window.showModalDialog
> >  pref("dom.disable_window_showModalDialog", true);
> >  
> > +// Enable implemented new html forms
> 
> implemented or experimental? ;)
I was using implemented to note that not all experimental forms were ready yet. Doesn't really mater either way. They should be soon :)
Raphael, I think you will have to update your patch. It's likely bitrotted by the landing of bug 780080.
Attached patch patchSplinter Review
Attachment #650017 - Attachment is obsolete: true
Attachment #650266 - Flags: review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/38190b5c8d29
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
blocking-basecamp: ? → -
Blocks: 446510
You need to log in before you can comment on or make changes to this bug.