IonMonkey: Try to enter outer loops rather than inner loops via OSR

RESOLVED FIXED

Status

()

Product:
Core
Component:
JavaScript Engine
RESOLVED FIXED
Reported:
5 years ago
Modified:
5 years ago

People

(Reporter: jandem, Assigned: jandem)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [ion:p1:fx18])

Attachments

(1 attachment)

Patch
15.64 KB, patch
dvander
: review+
bhackett
: review+
Details | Diff | Splinter Review
(Assignee)

Description

•
5 years ago 
Created attachment 649764 [details] [diff] [review]
Patch

This patch changes the recompile checks inserted by JM and Ion to use a slightly higher threshold for inner loops. The result is that we are more likely to enter outer loops instead of inner loops via OSR.

This closes about half the gap with JM+TI on ss-fannkuch (the rest seems to be compilation time, we are now faster than JM+TI on the modified benchmark in bug 777572), fixes the micro-benchmark in bug 779860 comment 0 and is a small v8-richards win.
Attachment #649764 - Flags: review?(dvander)
Attachment #649764 - Flags: review?(bhackett1024)
Whiteboard: [ion:p1:fx18]
Attachment #649764 - Flags: review?(dvander) → review+
Attachment #649764 - Flags: review?(bhackett1024) → review+
 (Assignee)

Comment 1

•
5 years ago 
https://hg.mozilla.org/projects/ionmonkey/rev/5e461fb2250a
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
 (Assignee)

Updated

•
5 years ago
Duplicate of this bug: 779860
You need to log in before you can comment on or make changes to this bug.