Closed
Bug 780975
Opened 12 years ago
Closed 12 years ago
Remove the window parameter to ElementTouchHelper.anyElementFromPoint and .elementFromPoint
Categories
(Firefox for Android Graveyard :: Toolbar, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 18
People
(Reporter: kats, Assigned: kats)
Details
Attachments
(1 file)
7.27 KB,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
This is spun out of https://bugzilla.mozilla.org/show_bug.cgi?id=779920#c4 and https://bugzilla.mozilla.org/show_bug.cgi?id=779920#c5 - it seems unnecessarily error-prone to have the window parameters to these functions, since they're always the same thing (BrowserApp.selectedBrowser.contentWindow). I would prefer to take out the parameters altogether and document the assumption that the coordinate parameters are relative to the top-level window.
Assignee | ||
Comment 1•12 years ago
|
||
Attachment #659311 -
Flags: review?(mark.finkle)
Updated•12 years ago
|
Attachment #659311 -
Flags: review?(mark.finkle) → review+
Assignee | ||
Comment 2•12 years ago
|
||
Comment 3•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 18
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•