781136 - Add flashplayerplugin_*.exe to Flash detection

Status: RESOLVED FIXED

(Socorro :: Backend, task)

Description

[Robert Kaiser]

We're nowadays also getting crashes in the Flash Player sandbox .exe, e.g. https://crash-stats.mozilla.com/report/list?signature=flashplayerplugin_11_3_300_270.exe%400x3e9aa

As we only detect Flash versions for modules that match a certain file pattern, we need to add flashplayerplugin_.*\.exe or something similar to that pattern.

Comment 1

[Robert Kaiser]

The module is actually called FlashPlayerPlugin_11_3_300_270.exe from what I see - in case the matching there is case-sensitive.

Comment 2

[Robert Kaiser]

https://github.com/mozilla/socorro/pull/779 is the PR for this, I hope I got it right.

Comment 3

[Benjamin Smedberg]

I haven't noticed any problems with the existing data: are there reports that are currently incorrect?

Comment 4

[Robert Kaiser]

Crashes like the ones linked in comment #0, where there's only FlashPlayerPlugin_*.exe in the modules list and not the .dll current don't show up with Flash versions. My PR changes that so that they do and we use the version of the .exe as the Flash version.

Comment 5

[Robert Kaiser]

Created a new clean PR for this: https://github.com/mozilla/socorro/pull/804

Comment 6

[[github robot]]

Commits pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/3812aa22f3c225066f44f8d0359967ca15c99ddc
Fixes bug 781136 - Add flashplayerplugin_*.exe to Flash detection

https://github.com/mozilla/socorro/commit/a800fe5f7fc14738a990635ba0e460d6df853b64
Merge pull request #804 from KaiRo-at/bug781136

Bug 781136 - Add flashplayerplugin_*.exe to Flash detection