Last Comment Bug 781138 - Empty .mkdir.done files are bundled with packages
: Empty .mkdir.done files are bundled with packages
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Build Config (show other bugs)
: Trunk
: All All
: -- normal (vote)
: ---
Assigned To: Takanori MATSUURA
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-08-08 05:03 PDT by Takanori MATSUURA
Modified: 2012-08-16 18:43 PDT (History)
3 users (show)
ryanvm: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Possible fix (3.25 KB, patch)
2012-08-09 15:35 PDT, Takanori MATSUURA
mh+mozilla: review+
Details | Diff | Splinter Review

Description Takanori MATSUURA 2012-08-08 05:03:45 PDT
Maybe after checking in bug 773202, there are many empty .mkdir.done files are bundled with packages.


firefox-17.0a1.en-US.linux-x86_64.tar.bz2:firefox/omni.ja
  modules/services-notifications/.mkdir.done

firefox-17.0a1.en-US.linux-x86_64.tests.zip
  mochitest/extensions/.mkdir.done  
  mochitest/extensions/specialpowers/chrome/.mkdir.done  
  mochitest/mochijar/chrome/.mkdir.done  
  modules/.mkdir.done  
  modules/services-common/.mkdir.done  
  reftest/reftest/chrome/.mkdir.done  

thunderbird-17.0a1.en-US.linux-x86_64.tests.zip
  mochitest/extensions/.mkdir.done  
  mochitest/extensions/specialpowers/chrome/.mkdir.done  
  mochitest/mochijar/chrome/.mkdir.done  
  modules/.mkdir.done  
  reftest/reftest/chrome/.mkdir.done  

xulrunner-17.0a1.en-US.linux-x86_64.sdk.tar.bz2
  xulrunner-sdk/bin/chrome/.mkdir.done
  xulrunner-sdk/idl/.mkdir.done
  xulrunner-sdk/include/.mkdir.done

xulrunner-17.0a1.en-US.linux-x86_64.tar.bz2:xulrunner/omni.ja
  chrome/.mkdir.done
Comment 1 Ted Mielczarek [:ted.mielczarek] 2012-08-08 05:08:02 PDT
I'm not particularly worried about the test package or the xulrunner package, but we should make sure we skip these when creating the omnijar archive.
Comment 2 Takanori MATSUURA 2012-08-09 15:35:49 PDT
Created attachment 650700 [details] [diff] [review]
Possible fix

For omni.ja archive:
Add \*/.mkdir.done to NON_OMNIJAR_FILES

For packages:
Add --exclude=".mkdir.done" to CREATE_FINAL_TAR (for tar archive) or \*/.mkdir.done to INNER_MAKE_PACKAGE (for zip archive)

https://tbpl.mozilla.org/?tree=Try&rev=6e207bec61ca
Comment 4 Takanori MATSUURA 2012-08-16 18:43:57 PDT
https://hg.mozilla.org/mozilla-central/rev/79e57b09177b

Note You need to log in before you can comment on or make changes to this bug.