Closed Bug 781138 Opened 8 years ago Closed 8 years ago

Empty .mkdir.done files are bundled with packages

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: t.matsuu, Assigned: t.matsuu)

Details

Attachments

(1 file)

Maybe after checking in bug 773202, there are many empty .mkdir.done files are bundled with packages.


firefox-17.0a1.en-US.linux-x86_64.tar.bz2:firefox/omni.ja
  modules/services-notifications/.mkdir.done

firefox-17.0a1.en-US.linux-x86_64.tests.zip
  mochitest/extensions/.mkdir.done  
  mochitest/extensions/specialpowers/chrome/.mkdir.done  
  mochitest/mochijar/chrome/.mkdir.done  
  modules/.mkdir.done  
  modules/services-common/.mkdir.done  
  reftest/reftest/chrome/.mkdir.done  

thunderbird-17.0a1.en-US.linux-x86_64.tests.zip
  mochitest/extensions/.mkdir.done  
  mochitest/extensions/specialpowers/chrome/.mkdir.done  
  mochitest/mochijar/chrome/.mkdir.done  
  modules/.mkdir.done  
  reftest/reftest/chrome/.mkdir.done  

xulrunner-17.0a1.en-US.linux-x86_64.sdk.tar.bz2
  xulrunner-sdk/bin/chrome/.mkdir.done
  xulrunner-sdk/idl/.mkdir.done
  xulrunner-sdk/include/.mkdir.done

xulrunner-17.0a1.en-US.linux-x86_64.tar.bz2:xulrunner/omni.ja
  chrome/.mkdir.done
I'm not particularly worried about the test package or the xulrunner package, but we should make sure we skip these when creating the omnijar archive.
Attached patch Possible fixSplinter Review
For omni.ja archive:
Add \*/.mkdir.done to NON_OMNIJAR_FILES

For packages:
Add --exclude=".mkdir.done" to CREATE_FINAL_TAR (for tar archive) or \*/.mkdir.done to INNER_MAKE_PACKAGE (for zip archive)

https://tbpl.mozilla.org/?tree=Try&rev=6e207bec61ca
Attachment #650700 - Flags: review?(mh+mozilla)
Attachment #650700 - Flags: review?(mh+mozilla) → review+
Keywords: checkin-needed
Assignee: nobody → t.matsuu
Status: NEW → ASSIGNED
https://hg.mozilla.org/mozilla-central/rev/79e57b09177b
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.