781139 - Site-identity's text overlaps for different locales

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: General, defect)

Description

[Cristian Nicolae (:xti)]

Attachment: screenshot

Firefox 17.0a1 (2012-08-08)
Device: Galaxy Nexus
OS: Android 4.1.1

Steps to reproduce:
1. Change the OS language to Portuguese
2. Open Fennec
3. Go to gmail.com
4. Tap on the blue lock from the right side of the URL Bar

Expected result:
The site-identity popup is triggered after step 4. There are no layout issues on it.

Actual result:
The last text line on the site identity popup is overlapped at step 4 (see attached screenshot)
This issue is reproducing for other languages like for Nederlands for example.

Comment 1

[:Margaret Leibovic]

Whoa, that's a lot of overlap.

Ian, how do you think we should address this? The "Verified by: " value can be arbitrarily long, since it's provided by the cert. Should we just ellipsize it? Or marquee it?

Comment 2

[Ian Barlow (:ibarlow)]

Oh dear. That is... very bad, heh.

We might have to break those onto two lines. And then if they are still too long, ellipsize the text.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Ian Barlow (:ibarlow) from comment #2)
> Oh dear. That is... very bad, heh.
> 
> We might have to break those onto two lines. And then if they are still too
> long, ellipsize the text.

IMO, ellipsize is BAD. We want people to be able to read this info. It's security related. I think we need to use the marquee feature and keep this a single line.

Comment 4

[Ian Barlow (:ibarlow)]

I thought someone might say that. Fair enough. Marquee away.

Comment 5

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch

Patch solves the issue.
We might need to revisit after defining the textAppearanceSmall and textAppearanceMedium later.

Comment 6

[:Margaret Leibovic]

Comment on attachment 650715 [details] [diff] [review]
Patch

Thanks for working on a patch! This definitely looks better than before, but I'm seeing the word "Encrypted" wrap strangely when there's a really long verifier string. I'll post a screenshot. Also, it would be good for ibarlow to look at it, since he might have suggestions/demands ;)

Unfortunately, there's also a site_identity_popup.xml in layout-large-v11, but I just ran a diff and only one line is different between them, so maybe this is a good opportunity to combine them.

leibovic$ diff layout/site_identity_popup.xml layout-large-v11/site_identity_popup.xml 
10c10
<     <RelativeLayout android:layout_width="fill_parent"
---
>     <RelativeLayout android:layout_width="@dimen/site_identity_popup_width"

Comment 7

[:Margaret Leibovic]

Attachment: screenshot with patch

Comment 8

[Cristian Nicolae (:xti)]

I can reproduce this issue on the latest Nightly on gmail.com (en-US locale).

--
Firefox 19.0a1 (2012-10-18)
Device: Galaxy S2
OS: Android 4.0.3

Comment 9

[:Margaret Leibovic]

Comment on attachment 650733 [details]
screenshot with patch

This screenshot doesn't look valid anymore.

Comment 10

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.