781143 - java.lang.NullPointerException: at org.mozilla.gecko.GeckoApp.onBackPressed(GeckoApp.java)

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Scoobidiver (away)]

There are one crash in 17.0a1, one in 16.0a2 and it's #87 top crasher in 15.0b3. Here is a crash report: bp-c5e1c9c7-bf50-43fa-9c2c-e80582120808.

java.lang.NullPointerException
	at org.mozilla.gecko.GeckoApp.onBackPressed(GeckoApp.java:2525)
	at android.app.Activity.onKeyUp(Activity.java:2126)
	at android.view.KeyEvent.dispatch(KeyEvent.java:2575)
	at android.app.Activity.dispatchKeyEvent(Activity.java:2356)
	at com.android.internal.policy.impl.PhoneWindow$DecorView.dispatchKeyEvent(PhoneWindow.java:1806)
	at android.view.ViewRootImpl.deliverKeyEventPostIme(ViewRootImpl.java:3365)
	at android.view.ViewRootImpl.deliverKeyEvent(ViewRootImpl.java:3326)
	at android.view.ViewRootImpl.handleMessage(ViewRootImpl.java:2488)
	at android.view.ViewRootImpl.processInputEvents(ViewRootImpl.java:870)
	at android.view.ViewRootImpl.handleMessage(ViewRootImpl.java:2501)
	at android.os.Handler.dispatchMessage(Handler.java:99)
	at android.os.Looper.loop(Looper.java:137)
	at android.app.ActivityThread.main(ActivityThread.java:4424)
	at java.lang.reflect.Method.invokeNative(Native Method)
	at java.lang.reflect.Method.invoke(Method.java:511)
	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:784)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:551)
	at dalvik.system.NativeStart.main(Native Method)

More reports at:
https://crash-stats.mozilla.com/report/list?signature=java.lang.NullPointerException%3A+at+org.mozilla.gecko.GeckoApp.onBackPressed%28GeckoApp.java%29

Comment 1

[:Margaret Leibovic]

It looks like this could happen if mDoorHangerPopup isn't initialized yet:
https://hg.mozilla.org/releases/mozilla-beta/file/tip/mobile/android/base/GeckoApp.java#l2517

We would be able to fix that with a null check.

Comment 2

[:Margaret Leibovic]

Attachment: patch

It's possible the user could hit back before we call initializeChrome, so we should guard against that.

Comment 3

[:Margaret Leibovic]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2689e1c1883c

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/2689e1c1883c

Comment 5

[Aaron Train [:aaronmt]]

Channel uplift?

Comment 6

[:Margaret Leibovic]

Comment on attachment 650641 [details] [diff] [review]
patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): n/a
User impact if declined: crashes
Testing completed (on m-c, etc.): landed on m-c 8/9 
Risk to taking this patch (and alternatives if risky): low-risk null check 
String or UUID changes made by this patch: n/a

Comment 7

[Scoobidiver (away)]

It's already in Aurora.

Comment 8

[:Margaret Leibovic]

Comment on attachment 650641 [details] [diff] [review]
patch

Good call, I got confused.

Comment 9

[bhavana bajaj [:bajaj]]

Comment on attachment 650641 [details] [diff] [review]
patch

Approving for beta as this has been on m-c for a while and aurora as well.

Comment 10

[:Margaret Leibovic]

https://hg.mozilla.org/releases/mozilla-beta/rev/2d8dbed6b9c1