78116 - nsIFileStream.cpp is deprecated. cookies should be using necko file io.

Status: VERIFIED FIXED

(Core :: Networking: Cookies, enhancement)

Description

[timeless]

SunOS 5.7 Generic_106541-15 sun4u sparc SUNW,Ultra-2
xlib cvs build from this morning.

http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/extensions/cookie/nsPermiss
ions.cpp&rev=1.7&mark=432-434#320

It's nice to know that something failed, and that it's not an error, but could 
we please tell the developer where the file lives? userChrome.css and 
userContent.css do this.  It would also be nice if for debugging purposes we 
found out _why_ the open failed (most likely case is file not found, but others 
do exist -- I presume)

Comment 1

[Doug Turner (:dougt)]

nsIFileStream.cpp is deprecated.  cookies should be using necko file io.

Comment 2

[timeless]

ok, not a networking bug, sorry. i don't see any cookie bugs for this so i'm 
morphing it.

Comment 3

[timeless]

poof

Comment 4

[[e-mail]]

taking

Comment 5

[[e-mail]]

fixed per dougt's recent minimo checkins

and also, simultaneously, by the rewrite ;)

Comment 6

[benc]

VERIFIED:

http://lxr.mozilla.org/mozilla1.0/ident?i=nsInputFileStream

shows several uses of nsInputFileStream in cookie code.

# extensions/cookie/nsCookies.cpp:

* View change log or Blame annotations line 1741

# extensions/cookie/nsPermissions.cpp:

* View change log or Blame annotations line 457

# extensions/cookie/nsUtils.cpp:

    * View change log or Blame annotations line 54
* line 82

# extensions/cookie/nsUtils.h:

* View change log or Blame annotations line 45



http://lxr.mozilla.org/mozilla/ident?i=nsInputFileStream

shows no current uses of of nsInputFileStream in cookie code.

Comment 7

[kimchiimg]

resize image thank for post