781191 - Door-hanger notification location too high up

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Aaron Train [:aaronmt]]

Attachment: Nightly (08/08) - Screenshot

See screenshot

Comment 1

[:Margaret Leibovic]

I was able to reproduce this. I'll investigate today. I bet it's a regression from bug 732336.

Comment 2

[:Margaret Leibovic]

I can only reproduce this on my Galaxy Nexus running JB. That makes me feel better about not noticing this while developing my patches on my Nexus S running GB :)

Comment 3

[:Margaret Leibovic]

Attachment: patch

The problem is that we're replacing the browser toolbar view when we rotate the device on ICS/JB, so the mAnchor we're storing with the doorhanger popup becomes invalid. I feel like there might be a more elegant way to do this, but this patch gets the job done.

Comment 4

[Wesley Johnston (:wesj)]

Comment on attachment 650240 [details] [diff] [review]
patch

Review of attachment 650240 [details] [diff] [review]:
-----------------------------------------------------------------

Yeah. I think the right thing to do here is probably throw away this view and recreate it lazily next time we need it. Then we'd need some sort of DoorHangerManager that kept track of all the state we want to save though. This seems simple enough.

Comment 5

[:Margaret Leibovic]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2691aa65ac97

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/2691aa65ac97

Comment 7

[Andreea Pod]

Attachment: Nightly 09/21

This is how it looks on Nightly 18.0a1 (2012-09-21)

Comment 8

[Andreea Pod]

Attachment: Aurora 09/21

This is how it looks on Aurora 17.oa2 (2012-09-21)

Device: Samsung Galaxy Nexus
OS: Android 4.1.1

Comment 9

[:Margaret Leibovic]

I'm closing this bug again because I can't reproduce the up-too-high problem. I filed bug 808248 as a follow-up to continue to refine the positioning of these doorhanger arrows.

Comment 10

[Cristian Nicolae (:xti)]

I cannot reproduce this issue on the latest Nightly, Aurora and Beta builds. Closing bug as verified fixed on:

Firefox 19.0a1 (2012-11-08)
Device: Galaxy S2
OS: Android 4.0.3