78123 - Add PageInfo security tab

Status: VERIFIED FIXED

(Core Graveyard :: Security: UI, defect)

Description

[Terry Hayes]

(Tracking bug for development work)

This bug covers development work for the UI and associated support functions for
the security tab of Page Info.

Comment 1

[Terry Hayes]

Attachment: implementation patch

Comment 2

[Terry Hayes]

review please?

Comment 3

[Javier Delgadillo]

2 things:
1) I don't think it is necessary to pass 0 as an initializer to a nsCOMPtr var 
like is done for nsSSLInfo
2) There's a printf that isn't surrounded by ifdef DEBUG in OnSecurityChange.

After that's done, r=javi

Comment 4

[Terry Hayes]

Attachment: Updated patch

Comment 5

[Terry Hayes]

r=javi on the updated patch.

scc: can you sr?

Comment 6

[Terry Hayes]

*** Bug 49697 has been marked as a duplicate of this bug. ***

Comment 7

[Scott Collins]

There might be some savings in using |NS_NAMED_LITERAL_STRING| over
|NS_LITERAL_STRING| when you will use the same literal string several times in
one function.

For consistency and readability, prefer

  NS_IF_ADDREF(*_result);

over

+  if (*_result) NS_ADDREF(*_result);

You used the former in several places, and the latter in at least one.


You might want to add asserts to test `result' arguments, e.g.,

  NS_ASSERTION(_result, "non-NULL destination required");
  *_result = mServerCert;
  NS_IF_ADDREF(*_result);
  return NS_OK;

The JS looked reasonable to me, but I'm not a JS-lawyer, so you might want a
second opinion there.  I would like you to add the assertions, because I think
it may help you later, but I saw nothing that would make me want to stop you
from checking this in.

sr=scc

Comment 8

[Terry Hayes]

checked in.

To verify:  go to a secure page and click the lock icon.  The page info window
should open and the correct security data should be displayed.

You can also test with weak encryption sites (aka.mcom.com is one) and also on
unsecured pages.

Comment 9

[John Unruh]

Verified with the 5/3 WinNT Netscape 6 build.