78127 - xsl:choose screws up Action and CurrentNode stack

Status: VERIFIED FIXED

(Core :: XSLT, defect)

Description

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

The code for xsl:choose |return|s after doing it deeds. That bypasses the
|ps->popAction(); ps->popCurrentNode();| at the buttom of processTopLevel. I
also removed one extra string-copy so I had to make getElementType take a |const
String&| insead of |String&|

Most of the changes are indentations so I made a diff -uw

Comment 1

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Attachment: this should do it... diffed with -uw

Comment 2

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

As you might have notived, my plan to get you guys reviewing is to flood you 
with patches, so theres no point in waiting ;-)

There simply is no escape... muahaHAHA

(I really need some sleep)

Comment 3

[Keith Visco]

Nice fix....looks good to me. r=me

Comment 4

[Peter Van der Beken [:peterv]]

r/a=peterv.

Comment 5

[Axel Hecht]

sicking, I need the diff -u, too. I hope, you still have the tree, otherwise
we'd have to get the indentions redone.

Thanx

Axel

Comment 6

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

I'll get you a -u one as soon as I get my builds going again... hopefully this 
week

Comment 7

[Axel Hecht]

Attachment: that was easy, I could do that ;-), full diff -u

Comment 8

[Mike Shaver (:shaver emeritus)]

sr=shaver

Comment 9

[Axel Hecht]

fix checked in, Axel

Comment 10

[Axel Hecht]

bitching buttons, verfication spam