The default bug view has changed. See this FAQ.

Remove make rules from services/

RESOLVED FIXED in mozilla17

Status

()

Core
Build Config
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: gps, Assigned: gps)

Tracking

(Blocks: 1 bug)

Trunk
mozilla17
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 650245 [details] [diff] [review]
Use generic rules, v1

This is like bug 759487 but for all other Makefile.in's in services/.

services/common/Makefile.in still has some rules for functionality I added a few months back to run some standalone test servers. But, the rules come after rules.mk, so I don't think it will be a problem.

The new generic install rule rocks!
Attachment #650245 - Flags: review?(mh+mozilla)
Comment on attachment 650245 [details] [diff] [review]
Use generic rules, v1

Review of attachment 650245 [details] [diff] [review]:
-----------------------------------------------------------------

::: services/aitc/Makefile.in
@@ +23,5 @@
>    $(NULL)
>  
>  PREF_JS_EXPORTS = $(srcdir)/services-aitc.js
>  
> +AITC_MODULE_FILES := $(foreach module,$(aitc_modules),modules/$(module))

$(addprefix modules/,$(aitc_modules))

@@ +24,5 @@
>  
>  PREF_JS_EXPORTS = $(srcdir)/services-aitc.js
>  
> +AITC_MODULE_FILES := $(foreach module,$(aitc_modules),modules/$(module))
> +AITC_MODULE_DEST := $(FINAL_TARGET)/modules/services-aitc

You don't need config.mk if you use =.

::: services/common/Makefile.in
@@ +38,1 @@
>  TESTING_JS_MODULES := $(foreach file,$(testing_modules),modules-testing/$(file))

Can you change this to use addprefix while you're here?
Attachment #650245 - Flags: review?(mh+mozilla) → review+
(Assignee)

Updated

5 years ago
Duplicate of this bug: 781498
(Assignee)

Comment 3

5 years ago
https://hg.mozilla.org/services/services-central/rev/f9452e60f4ad
Assignee: nobody → gps
Whiteboard: [fixed in services]
Target Milestone: --- → mozilla17
(Assignee)

Comment 4

5 years ago
https://hg.mozilla.org/mozilla-central/rev/f9452e60f4ad
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed in services]
You need to log in before you can comment on or make changes to this bug.