781307 - Remove make rules from services/

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Gregory Szorc [:gps]]

Attachment: Use generic rules, v1

This is like bug 759487 but for all other Makefile.in's in services/.

services/common/Makefile.in still has some rules for functionality I added a few months back to run some standalone test servers. But, the rules come after rules.mk, so I don't think it will be a problem.

The new generic install rule rocks!

Comment 1

[Mike Hommey [:glandium]]

Comment on attachment 650245 [details] [diff] [review]
Use generic rules, v1

Review of attachment 650245 [details] [diff] [review]:
-----------------------------------------------------------------

::: services/aitc/Makefile.in
@@ +23,5 @@
>    $(NULL)
>  
>  PREF_JS_EXPORTS = $(srcdir)/services-aitc.js
>  
> +AITC_MODULE_FILES := $(foreach module,$(aitc_modules),modules/$(module))

$(addprefix modules/,$(aitc_modules))

@@ +24,5 @@
>  
>  PREF_JS_EXPORTS = $(srcdir)/services-aitc.js
>  
> +AITC_MODULE_FILES := $(foreach module,$(aitc_modules),modules/$(module))
> +AITC_MODULE_DEST := $(FINAL_TARGET)/modules/services-aitc

You don't need config.mk if you use =.

::: services/common/Makefile.in
@@ +38,1 @@
>  TESTING_JS_MODULES := $(foreach file,$(testing_modules),modules-testing/$(file))

Can you change this to use addprefix while you're here?

Comment 3

[Gregory Szorc [:gps]]

https://hg.mozilla.org/services/services-central/rev/f9452e60f4ad

Comment 4

[Gregory Szorc [:gps]]

https://hg.mozilla.org/mozilla-central/rev/f9452e60f4ad