781336 - When attaching a file if a desired reviewer is not allowed to see the bug, review request goes through without any warning

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: User Interface, defect)

Description

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Thanks to djvj wrt. bug 781214, whose reviewer (mjrosenb) was not allowed to see the bug, the review request fell through silently and ended up as a r? "from the air".

If one sets the reviewer in the patch details page with the reviewer still not being allowed to see the bug, there is a warning shown.

This warning should show at the first situation instead of falling through silently.


Excerpt of chat:

14:09   dkl: gkw, understood. ok looking at the code, it is configured to skip the requestee in the case the requestee is not allowed to see the bug/attachment
14 [review]:10   gkw: dkl: but the warning does not show when this is first done, as it's not immediately obvious, am i right djvj ?         
14:10   dkl: gkw, we can (BMO) change it to not allow and throw a proper error invalidating the entire change if people think that would be better to do so. Please file a BMO bug with the description and we can discuss it there to see if we want to do that
14:10   dkl: gkw, right it silently undefs the requestee and allows the review? to go on
14:10   gkw: dkl: i guess the point is that the warning should show if the requested reviewer is not allowed to see the bug
14:11   gkw: dkl: i see, ok i'll file the bug, thanks
14:11  <         dkl> | by setting SKIP_REQUESTEE_ON_ERROR = 0 in our instance, we would then throw an error instead
14:11   dkl: gkw, thx

Comment 1

[Andrew McCreight [:mccr8]]

This is happening fairly frequently with security bugs.

Comment 2

[Frédéric Buclin]

(In reply to Gary Kwong [:gkw, :nth10sd] from comment #0)
> This warning should show at the first situation instead of falling through
> silently.

It doesn't fall through silently. People are simply not reading what Bugzilla displays.

Comment 3

[:glob ✱]

(In reply to Frédéric Buclin from comment #2)
> It doesn't fall through silently. People are simply not reading what
> Bugzilla displays.

it does fall through silently; as per comment 0 this only happens when you ask for a reviewer when attaching a file.

i'll toggle SKIP_REQUESTEE_ON_ERROR now.

Comment 4

[:glob ✱]

Committing to: bzr+ssh://[e-mail]/bmo/4.0/
modified Bugzilla/Flag.pm
Committed revision 8365.

Committing to: bzr+ssh://[e-mail]/bmo/4.2/
modified Bugzilla/Flag.pm
Committed revision 8390.