Closed
Bug 781388
Opened 13 years ago
Closed 13 years ago
IonMonkey: Add infalliblity to appropriate DOM method calls.
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: efaust, Assigned: efaust)
References
Details
(Whiteboard: [ion:t])
Attachments
(1 file)
|
2.74 KB,
patch
|
sstangl
:
review+
|
Details | Diff | Splinter Review |
We need to handle infallibility on DOM methods.
|
Assignee | |
Comment 1•13 years ago
|
||
Add infalliblity capabilities to CodeGenerator::visitCallDOMNative()
Attachment #650417 -
Flags: review?(sstangl)
|
||
Comment 2•13 years ago
|
||
Comment on attachment 650417 [details] [diff] [review]
Trivial patch
Review of attachment 650417 [details] [diff] [review]:
-----------------------------------------------------------------
::: js/src/ion/CodeGenerator.cpp
@@ +639,5 @@
> + }
> + masm.bind(&success);
> +
> + // The next instruction is removing the footer of the exit frame, so there
> + // is no need for leaveFakeExitFrame.
This comment is applicable to both blocks: it can be taken out of the else {}.
Attachment #650417 -
Flags: review?(sstangl) → review+
|
||
Updated•13 years ago
|
Whiteboard: [ion:t]
|
|
Assignee | |
Comment 3•13 years ago
|
||
https://hg.mozilla.org/projects/ionmonkey/rev/0eb2f7a48004
https://hg.mozilla.org/projects/ionmonkey/rev/3817beae7e3c
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•