781388 - IonMonkey: Add infalliblity to appropriate DOM method calls.

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Eric Faust [:efaust]]

We need to handle infallibility on DOM methods.

Comment 1

[Eric Faust [:efaust]]

Attachment: Trivial patch

Add infalliblity capabilities to CodeGenerator::visitCallDOMNative()

Comment 2

[Sean Stangl [:sstangl]]

Comment on attachment 650417 [details] [diff] [review]
Trivial patch

Review of attachment 650417 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/ion/CodeGenerator.cpp
@@ +639,5 @@
> +        }
> +        masm.bind(&success);
> +
> +        // The next instruction is removing the footer of the exit frame, so there
> +        // is no need for leaveFakeExitFrame.

This comment is applicable to both blocks: it can be taken out of the else {}.

Comment 3

[Eric Faust [:efaust]]

https://hg.mozilla.org/projects/ionmonkey/rev/0eb2f7a48004
https://hg.mozilla.org/projects/ionmonkey/rev/3817beae7e3c