Closed Bug 781390 Opened 8 years ago Closed 7 years ago

Make barrier verifier testing work better with the methodjit

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla17

People

(Reporter: billm, Assigned: billm)

References

Details

Attachments

(1 file)

Attached patch patchSplinter Review
While looking at bug 774859, I was trying to write a test case using the write barrier verifier and the methodjit. However, it turns out to be almost impossible to do that. We're supposed to invoke the operation callback in the methodjit when running with gczeal(4). However, each time we call StartVerifyPreBarriers, it calls setNeedsBarrier, which causes us to return to the interpreter.

This patch makes testing a little easier by always compiling with barriers when gczeal==4. That way we don't have to return to the interpreter each time we do Start/EndVerifyPreBarriers.
Attachment #650380 - Flags: review?(bhackett1024)
Attachment #650380 - Flags: review?(bhackett1024) → review+
https://hg.mozilla.org/mozilla-central/rev/07f21ec5d516
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
Depends on: 783421
Looks like this (or a subset of) needs to be landed on mozilla-aurora to prevent bustage by the landing of the patch from bug 774859
Blocks: 774859
You need to log in before you can comment on or make changes to this bug.