Last Comment Bug 781403 - cull "performance" jstests
: cull "performance" jstests
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla17
Assigned To: general
:
: Jason Orendorff [:jorendorff]
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-08-08 18:42 PDT by :Benjamin Peterson
Modified: 2012-08-10 01:57 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
kill most js performance tests (25.07 KB, patch)
2012-08-08 18:57 PDT, :Benjamin Peterson
dmandelin: review+
Details | Diff | Splinter Review

Description :Benjamin Peterson 2012-08-08 18:42:45 PDT
Most of these, like js1_5/Regress/regress-169559.js (which checks that global access is less than 2.5 times slower than local access), are useless. They should be examined and killed as necessary.
Comment 1 Luke Wagner [:luke] 2012-08-08 18:54:14 PDT
Yes, please.  I would be surprised if most of them haven't been turned off already.
Comment 2 :Benjamin Peterson 2012-08-08 18:57:03 PDT
Created attachment 650416 [details] [diff] [review]
kill most js performance tests

Here is a patch removing all the tests that test BigO behavior. Of performance.tests, I left two leak tests and one of Date resolution. In theory, I suppose the leak tests are still applicable, but they definitely take a long time to run. Don't know about Date resolution. Comments welcome.
Comment 3 :Benjamin Peterson 2012-08-08 19:00:02 PDT
My favorite is one that tests that decompilation is quadratic. :)
Comment 5 Ed Morley [:emorley] 2012-08-10 01:57:39 PDT
https://hg.mozilla.org/mozilla-central/rev/a3c509c4d315

Note You need to log in before you can comment on or make changes to this bug.