cull "performance" jstests

RESOLVED FIXED in mozilla17

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Benjamin, Unassigned)

Tracking

unspecified
mozilla17
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
Most of these, like js1_5/Regress/regress-169559.js (which checks that global access is less than 2.5 times slower than local access), are useless. They should be examined and killed as necessary.

Comment 1

5 years ago
Yes, please.  I would be surprised if most of them haven't been turned off already.
(Reporter)

Comment 2

5 years ago
Created attachment 650416 [details] [diff] [review]
kill most js performance tests

Here is a patch removing all the tests that test BigO behavior. Of performance.tests, I left two leak tests and one of Date resolution. In theory, I suppose the leak tests are still applicable, but they definitely take a long time to run. Don't know about Date resolution. Comments welcome.
Attachment #650416 - Flags: review?(dmandelin)
(Reporter)

Comment 3

5 years ago
My favorite is one that tests that decompilation is quadratic. :)
Attachment #650416 - Flags: review?(dmandelin) → review+
(Reporter)

Comment 4

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/a3c509c4d315

Comment 5

5 years ago
https://hg.mozilla.org/mozilla-central/rev/a3c509c4d315
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in before you can comment on or make changes to this bug.