Use -MMD flag for dependency generation

RESOLVED WONTFIX

Status

defect
RESOLVED WONTFIX
7 years ago
Last year

People

(Reporter: glandium, Assigned: glandium)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

Assignee

Description

7 years ago
We currently use -MD -MF file.pp to generate makefile dependencies based on preprocessor output. This includes system headers. We should add -MM so that system headers are not considered. This would remove a lot of file checking.

At the same time, we should consider the headers in $(DIST)/system_wrapper and $(DIST)/stl_wrappers as system headers.
Assignee

Comment 2

7 years ago
Actually, the -isystem part is not a good idea, as some of the wrappers are actually used for in-tree non-system headers. Using -isystem would make them fail to be used. Just limit to -MM.
Attachment #651110 - Flags: review?(ted.mielczarek)
Assignee

Updated

7 years ago
Attachment #650558 - Attachment is obsolete: true
Attachment #650558 - Flags: review?(ted.mielczarek)
Assignee

Comment 3

7 years ago
Erf, in fact -MM doesn't do the right thing. Replacing -MD with -MMD does.
Attachment #651115 - Flags: review?(ted.mielczarek)
Assignee

Updated

7 years ago
Attachment #651110 - Attachment is obsolete: true
Attachment #651110 - Flags: review?(ted.mielczarek)
Assignee

Updated

7 years ago
Summary: Add -MM flag for dependency generation → Use -MMD flag for dependency generation
Attachment #651115 - Flags: review?(ted.mielczarek) → review+
https://hg.mozilla.org/mozilla-central/rev/a1ba35958b98
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
Assignee

Comment 6

7 years ago
GCC sucks.
https://hg.mozilla.org/integration/mozilla-inbound/rev/60a42d321090
Depends on: 785679
Resolution: FIXED → WONTFIX
Target Milestone: mozilla17 → ---

Updated

Last year
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.