Closed Bug 781529 Opened 8 years ago Closed 8 years ago

Use -MMD flag for dependency generation

Categories

(Firefox Build System :: General, defect)

All
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(1 file, 2 obsolete files)

We currently use -MD -MF file.pp to generate makefile dependencies based on preprocessor output. This includes system headers. We should add -MM so that system headers are not considered. This would remove a lot of file checking.

At the same time, we should consider the headers in $(DIST)/system_wrapper and $(DIST)/stl_wrappers as system headers.
Actually, the -isystem part is not a good idea, as some of the wrappers are actually used for in-tree non-system headers. Using -isystem would make them fail to be used. Just limit to -MM.
Attachment #651110 - Flags: review?(ted.mielczarek)
Attachment #650558 - Attachment is obsolete: true
Attachment #650558 - Flags: review?(ted.mielczarek)
Erf, in fact -MM doesn't do the right thing. Replacing -MD with -MMD does.
Attachment #651115 - Flags: review?(ted.mielczarek)
Attachment #651110 - Attachment is obsolete: true
Attachment #651110 - Flags: review?(ted.mielczarek)
Summary: Add -MM flag for dependency generation → Use -MMD flag for dependency generation
Attachment #651115 - Flags: review?(ted.mielczarek) → review+
https://hg.mozilla.org/mozilla-central/rev/a1ba35958b98
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
GCC sucks.
https://hg.mozilla.org/integration/mozilla-inbound/rev/60a42d321090
Depends on: 785679
Resolution: FIXED → WONTFIX
Target Milestone: mozilla17 → ---
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.