Closed Bug 781676 Opened 8 years ago Closed 8 years ago

java.lang.NullPointerException: at org.mozilla.gecko.gfx.LayerView.onTouchEvent(LayerView.java) at com.android.internal.policy.impl.PhoneWindow$DecorView.superDispatchTouchEvent(PhoneWindow.java)

Categories

(Firefox for Android :: Toolbar, defect)

16 Branch
ARM
Android
defect
Not set
critical

Tracking

()

RESOLVED FIXED
Firefox 17
Tracking Status
firefox15 --- affected
firefox16 --- fixed
firefox17 --- fixed

People

(Reporter: scoobidiver, Assigned: kats)

References

Details

(Keywords: crash, regression, Whiteboard: [native-crash])

Crash Data

Attachments

(1 file)

There are one crash in 16.0a2/20120807 and one in 17.0a1/20120809: bp-b5ecd2f3-ef68-4174-b9c7-6ee4f2120809.

java.lang.NullPointerException
	at org.mozilla.gecko.gfx.LayerView.onTouchEvent(LayerView.java:117)
	at android.view.View.dispatchTouchEvent(View.java:5545)
	at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:1951)
	at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:1712)
	at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:1957)
	at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:1684)
	at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:1957)
	at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:1684)
	at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:1957)
	at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:1684)
	at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:1957)
	at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:1684)
	at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:1957)
	at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:1684)
	at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:1957)
	at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:1684)
	at com.android.internal.policy.impl.PhoneWindow$DecorView.superDispatchTouchEvent(PhoneWindow.java:1912)
	at com.android.internal.policy.impl.PhoneWindow.superDispatchTouchEvent(PhoneWindow.java:1371)
	at android.app.Activity.dispatchTouchEvent(Activity.java:2364)
	at com.android.internal.policy.impl.PhoneWindow$DecorView.dispatchTouchEvent(PhoneWindow.java:1860)
	at android.view.View.dispatchPointerEvent(View.java:5725)
	at android.view.ViewRootImpl.deliverPointerEvent(ViewRootImpl.java:2890)
	at android.view.ViewRootImpl.handleMessage(ViewRootImpl.java:2466)
	at android.view.ViewRootImpl.processInputEvents(ViewRootImpl.java:845)
	at android.view.ViewRootImpl.handleMessage(ViewRootImpl.java:2475)
	at android.os.Handler.dispatchMessage(Handler.java:99)
	at android.os.Looper.loop(Looper.java:137)
	at android.app.ActivityThread.main(ActivityThread.java:4575)
	at java.lang.reflect.Method.invokeNative(Native Method)
	at java.lang.reflect.Method.invoke(Method.java:511)
	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:789)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:556)
	at dalvik.system.NativeStart.main(Native Method)

More reports at:
https://crash-stats.mozilla.com/report/list?signature=java.lang.NullPointerException%3A+at+org.mozilla.gecko.gfx.LayerView.onTouchEvent%28LayerView.java%29
Regression from bug 770047. Potential NPE if you touch the screen before gecko is fully initialized. Patch coming shortly.
Assignee: nobody → bugmail.mozilla
Keywords: regression
Attached patch PatchSplinter Review
Attachment #650983 - Flags: review?(sriram)
Comment on attachment 650983 [details] [diff] [review]
Patch

Review of attachment 650983 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.
Attachment #650983 - Flags: review?(sriram) → review+
Comment on attachment 650983 [details] [diff] [review]
Patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 770047
User impact if declined: possible crash if touch events are delivered during startup. seems to be very rare according to crash-stats
Testing completed (on m-c, etc.): unable to repro, so unable to test
Risk to taking this patch (and alternatives if risky): mobile only, low-risk patch
String or UUID changes made by this patch: none
Attachment #650983 - Flags: approval-mozilla-beta?
Attachment #650983 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/20299820ca66
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 17
Comment on attachment 650983 [details] [diff] [review]
Patch

Since this is rare and not possible to test I'm only approving for Aurora so we can continue to collect crash data there, but not going to take the risk of landing this to Beta so late in the cycle.
Attachment #650983 - Flags: approval-mozilla-beta?
Attachment #650983 - Flags: approval-mozilla-beta-
Attachment #650983 - Flags: approval-mozilla-aurora?
Attachment #650983 - Flags: approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.