Closed Bug 781679 Opened 11 years ago Closed 11 years ago

Assert that we do not destroy the layer manager while in the middle of painting

Categories

(Core :: Graphics: Layers, defect)

Product:
Core
Component:
Graphics: Layers
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla17

People

(Reporter: joe, Assigned: joe)

Details

Attachments

(1 file)

assert that we're not in the middle of a transaction when switching layer managers
9.79 KB, patch
mattwoodrow
: review+
Details | Diff | Splinter Review 
Bug 773097 was caused by switching layer managers while in the middle of painting. We should set a bit when we start painting, and unset it after we're done, and then assert that the bit is false whenever we're changing layer managers.
Haven't been able to test this yet, because I didn't have a debug build on this Windows machine, but I believe it would have caught the bug.
Assignee: nobody → joe
Attachment #651542 - Flags: review?(matt.woodrow)
This patch does, indeed, work.
Attachment #651542 - Flags: review?(matt.woodrow) → review+
https://hg.mozilla.org/mozilla-central/rev/5c8fcc4cc760
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.