The default bug view has changed. See this FAQ.

Assert that we do not destroy the layer manager while in the middle of painting

RESOLVED FIXED in mozilla17

Status

()

Core
Graphics: Layers
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Joe Drew (not getting mail), Assigned: Joe Drew (not getting mail))

Tracking

unspecified
mozilla17
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Bug 773097 was caused by switching layer managers while in the middle of painting. We should set a bit when we start painting, and unset it after we're done, and then assert that the bit is false whenever we're changing layer managers.
(Assignee)

Comment 1

5 years ago
Created attachment 651542 [details] [diff] [review]
assert that we're not in the middle of a transaction when switching layer managers

Haven't been able to test this yet, because I didn't have a debug build on this Windows machine, but I believe it would have caught the bug.
Assignee: nobody → joe
Attachment #651542 - Flags: review?(matt.woodrow)
(Assignee)

Comment 2

5 years ago
This patch does, indeed, work.
Attachment #651542 - Flags: review?(matt.woodrow) → review+
(Assignee)

Comment 3

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/5c8fcc4cc760
Target Milestone: --- → mozilla17
https://hg.mozilla.org/mozilla-central/rev/5c8fcc4cc760
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.