Closed Bug 781692 Opened 8 years ago Closed 8 years ago
[b2g-bluetooth] Make Bluetooth
Adapter property setting functions always fire a DOMRequest
In BluetoothAdapter, if a Set* call is made and the member being set is already equal to the requested value, the function will return NS_OK instead of filling in and returning a DOMRequest. For sake of consistency, all these functions should always fire DOM requests.
For blocking-basecamp: This needs to be fixed so we don't have to check edge cases in gaia. Should be a fairly quick fix.
blocking-basecamp: --- → ?
Comment on attachment 650726 [details] [diff] [review] v1: Actually fire DOMRequests for Set* functions even when value is the same in BluetoothAdapter Looks good to me. Since we're going to remove GetProperties(), class GetPropertiesTask will not be called anywhere. Please check if it can be removed as well.
Attachment #650726 - Flags: review?(echou) → review+
I actually think this is a nice-to-have unless we find that there is actual gaia functionality breaking over this. That said, feel free to land this anyway.
blocking-basecamp: + → -
Attachment #650726 - Attachment is obsolete: true
Target Milestone: --- → mozilla17
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.