[b2g-bluetooth] Make BluetoothAdapter property setting functions always fire a DOMRequest

RESOLVED FIXED in mozilla17

Status

()

Core
DOM: Device Interfaces
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: qdot, Unassigned)

Tracking

Trunk
mozilla17
x86_64
Linux
Points:
---

Firefox Tracking Flags

(blocking-basecamp:-)

Details

Attachments

(1 attachment, 1 obsolete attachment)

In BluetoothAdapter, if a Set* call is made and the member being set is already equal to the requested value, the function will return NS_OK instead of filling in and returning a DOMRequest. For sake of consistency, all these functions should always fire DOM requests.
For blocking-basecamp: This needs to be fixed so we don't have to check edge cases in gaia. Should be a fairly quick fix.
Blocks: 727618
blocking-basecamp: --- → ?
Created attachment 650726 [details] [diff] [review]
v1: Actually fire DOMRequests for Set* functions even when value is the same in BluetoothAdapter
Attachment #650726 - Flags: review?(echou)
Comment on attachment 650726 [details] [diff] [review]
v1: Actually fire DOMRequests for Set* functions even when value is the same in BluetoothAdapter

Looks good to me. Since we're going to remove GetProperties(), class GetPropertiesTask will not be called anywhere. Please check if it can be removed as well.
Attachment #650726 - Flags: review?(echou) → review+
blocking-basecamp: ? → +
I actually think this is a nice-to-have unless we find that there is actual gaia functionality breaking over this.

That said, feel free to land this anyway.
blocking-basecamp: + → -
Created attachment 651558 [details] [diff] [review]
FINAL: Actually fire DOMRequests for Set* functions even when value is the same in BluetoothAdapter

Removed GetPropTask
Attachment #650726 - Attachment is obsolete: true
https://hg.mozilla.org/integration/mozilla-inbound/rev/4b26b044d57d
Target Milestone: --- → mozilla17

Comment 7

5 years ago
https://hg.mozilla.org/mozilla-central/rev/4b26b044d57d
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.