Note: There are a few cases of duplicates in user autocompletion which are being worked on.

GCd databases do not unblock additional databases.

RESOLVED FIXED in mozilla17

Status

()

Core
DOM: IndexedDB
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: khuey, Assigned: khuey)

Tracking

unspecified
mozilla17
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

11.35 KB, patch
Ben Turner (not reading bugmail, use the needinfo flag!)
: review+
Details | Diff | Splinter Review
Created attachment 650740 [details] [diff] [review]
Patch

Discovered this while grovelling around in Bug 775206.  Most of the patch is test code.
Attachment #650740 - Flags: review?(bent.mozilla)
Comment on attachment 650740 [details] [diff] [review]
Patch

Review of attachment 650740 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/indexedDB/TransactionThreadPool.cpp
@@ +449,5 @@
>  }
>  
>  bool
>  TransactionThreadPool::WaitForAllDatabasesToComplete(
> +                                   nsTArray<IDBDatabase*>& aDatabases,

Nit: Can you reformat these?

::: js/xpconnect/src/nsXPConnect.cpp
@@ +2971,5 @@
>          printf("No idea what this value is.\n");
>      }
>  }
> +
> +JS_EXPORT_API(void) DumpCompleteHeap()

Let's be safe and nullcheck these things so we don't accidentally crash from gdb.
Attachment #650740 - Flags: review?(bent.mozilla) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/5761e34e5247
Flags: in-testsuite+
https://hg.mozilla.org/mozilla-central/rev/5761e34e5247
https://hg.mozilla.org/mozilla-central/rev/86660d9e93b9
https://hg.mozilla.org/mozilla-central/rev/9be47a089c6a
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in before you can comment on or make changes to this bug.