Last Comment Bug 781700 - GCd databases do not unblock additional databases.
: GCd databases do not unblock additional databases.
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: DOM: IndexedDB (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla17
Assigned To: Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-08-09 18:00 PDT by Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary)
Modified: 2012-08-11 19:54 PDT (History)
1 user (show)
khuey: in‑testsuite+
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (11.35 KB, patch)
2012-08-09 18:00 PDT, Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary)
bent.mozilla: review+
Details | Diff | Splinter Review

Description Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary) 2012-08-09 18:00:12 PDT
Created attachment 650740 [details] [diff] [review]
Patch

Discovered this while grovelling around in Bug 775206.  Most of the patch is test code.
Comment 1 Ben Turner (not reading bugmail, use the needinfo flag!) 2012-08-09 19:13:04 PDT
Comment on attachment 650740 [details] [diff] [review]
Patch

Review of attachment 650740 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/indexedDB/TransactionThreadPool.cpp
@@ +449,5 @@
>  }
>  
>  bool
>  TransactionThreadPool::WaitForAllDatabasesToComplete(
> +                                   nsTArray<IDBDatabase*>& aDatabases,

Nit: Can you reformat these?

::: js/xpconnect/src/nsXPConnect.cpp
@@ +2971,5 @@
>          printf("No idea what this value is.\n");
>      }
>  }
> +
> +JS_EXPORT_API(void) DumpCompleteHeap()

Let's be safe and nullcheck these things so we don't accidentally crash from gdb.
Comment 2 Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary) 2012-08-10 09:18:05 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/5761e34e5247

Note You need to log in before you can comment on or make changes to this bug.