781700 - GCd databases do not unblock additional databases.

Status: RESOLVED FIXED

(Core :: Storage: IndexedDB, defect)

Description

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Attachment: Patch

Discovered this while grovelling around in Bug 775206.  Most of the patch is test code.

Comment 1

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 650740 [details] [diff] [review]
Patch

Review of attachment 650740 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/indexedDB/TransactionThreadPool.cpp
@@ +449,5 @@
>  }
>  
>  bool
>  TransactionThreadPool::WaitForAllDatabasesToComplete(
> +                                   nsTArray<IDBDatabase*>& aDatabases,

Nit: Can you reformat these?

::: js/xpconnect/src/nsXPConnect.cpp
@@ +2971,5 @@
>          printf("No idea what this value is.\n");
>      }
>  }
> +
> +JS_EXPORT_API(void) DumpCompleteHeap()

Let's be safe and nullcheck these things so we don't accidentally crash from gdb.

Comment 2

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5761e34e5247

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/5761e34e5247
https://hg.mozilla.org/mozilla-central/rev/86660d9e93b9
https://hg.mozilla.org/mozilla-central/rev/9be47a089c6a