Last Comment Bug 781713 - Inline getEditable() and remove unnecessary null checks
: Inline getEditable() and remove unnecessary null checks
Product: Firefox for Android
Classification: Client Software
Component: Keyboards and IME (show other bugs)
: Trunk
: ARM Android
-- normal (vote)
: Firefox 17
Assigned To: Chris Peterson [:cpeterson]
: Jim Chen [:jchen] [:darchons]
Depends on:
  Show dependency treegraph
Reported: 2012-08-09 18:28 PDT by Chris Peterson [:cpeterson]
Modified: 2012-08-15 18:47 PDT (History)
1 user (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

inline-getEditable.patch (11.33 KB, patch)
2012-08-09 18:28 PDT, Chris Peterson [:cpeterson]
blassey.bugs: review+
Details | Diff | Splinter Review

Description User image Chris Peterson [:cpeterson] 2012-08-09 18:28:13 PDT
Created attachment 650747 [details] [diff] [review]

GeckoInputConnection.mEditable can never be null, so calling getEditable() or checking for null mEditable is unnecessary. This patch simplifies the code by removing some pointless null checks and return paths.
Comment 1 User image Chris Peterson [:cpeterson] 2012-08-15 05:59:06 PDT
Comment 2 User image Ryan VanderMeulen [:RyanVM] 2012-08-15 18:47:01 PDT

Note You need to log in before you can comment on or make changes to this bug.