Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Inline getEditable() and remove unnecessary null checks

RESOLVED FIXED in Firefox 17

Status

()

Firefox for Android
Keyboards and IME
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: cpeterson, Assigned: cpeterson)

Tracking

Trunk
Firefox 17
ARM
Android
Points:
---

Firefox Tracking Flags

(firefox17 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 650747 [details] [diff] [review]
inline-getEditable.patch

GeckoInputConnection.mEditable can never be null, so calling getEditable() or checking for null mEditable is unnecessary. This patch simplifies the code by removing some pointless null checks and return paths.
Attachment #650747 - Flags: review?(blassey.bugs)
Attachment #650747 - Flags: review?(blassey.bugs) → review+
(Assignee)

Comment 1

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/9f49d90a18c7
status-firefox17: --- → fixed
https://hg.mozilla.org/mozilla-central/rev/9f49d90a18c7
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 17
You need to log in before you can comment on or make changes to this bug.