Closed
Bug 781713
Opened 13 years ago
Closed 13 years ago
Inline getEditable() and remove unnecessary null checks
Categories
(Firefox for Android Graveyard :: Keyboards and IME, defect)
Tracking
(firefox17 fixed)
RESOLVED
FIXED
Firefox 17
| Tracking | Status | |
|---|---|---|
| firefox17 | --- | fixed |
People
(Reporter: cpeterson, Assigned: cpeterson)
Details
Attachments
(1 file)
|
11.33 KB,
patch
|
blassey
:
review+
|
Details | Diff | Splinter Review |
GeckoInputConnection.mEditable can never be null, so calling getEditable() or checking for null mEditable is unnecessary. This patch simplifies the code by removing some pointless null checks and return paths.
Attachment #650747 -
Flags: review?(blassey.bugs)
|
||
Updated•13 years ago
|
Attachment #650747 -
Flags: review?(blassey.bugs) → review+
|
Assignee | |
Comment 1•13 years ago
|
||
status-firefox17:
--- → fixed
|
||
Comment 2•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 17
|
||
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•