781766 - SIPCC ToDo List

Status: RESOLVED FIXED

(Core :: WebRTC: Signaling, defect)

Description

[enda mannion (:emannion)]

All this work will have to be done keeping in mind not to break the existing SIP Stack.  Do this using the SDPMode config item.

-Use GSM State machine to ensure correct ordering of JSEP calls and report when calls are made in the wrong order.

-Dynamically allocate SDP strings when passed in from the API.

-Maybe block JSEP API's until SIPCC is started or report error until its started.

-Remove any warnings from SIPCC code on all platforms.

-Remove network interface enumeration code from PeerConnectionCtx.

-Fix some memory leaks.

- AddStream and RemoveStream handle multiple tracks

- Improve JSEP error handling, either send to logging or implement new callbacks mechanism to send to surface.

- Remove much code under ./src/media such as WebRrcAudioProvider and WebRtcVideoProvider etc.

- remove NO_WEBRTC_VIDEO from code

- prevent calls to timers when in SDPMode: autoAnswerTimer, revertTimer, err_onhook_tmr, maybe a few more

- There are other extensions to SDP to be added.

- Handle adding multiple streams and tracks.

- Remove other unused code, some in plat folders is not used. Still some code around the config_parser that is unused.

Comment 1

[Ethan Hugg [:ehugg]]

- double-check all instances of strcpy, strcat, strncpy, strncat to ensure that they do not overwrite their bounds and null-term strings.  Replace most with sstrncpy and sstrncat.

- check all instances of memcpy and memmove for possible overwrites.

- Eliminate duplicate code in cpr, especially between linux/darwin.

- Eliminate most of cpr, replace os-specific functions with one matching function that uses nspr.

- Move signaling/media-conduit under signaling/src

- Update so it builds on Android and B2G.

Comment 2

[Ethan Hugg [:ehugg]]

Attachment: Move media-conduit into source and un-duplicate some string functions

Comment 3

[Ethan Hugg [:ehugg]]

I'm going to mark this as resolved-fixed.  The patch that is here landed on M-C in the alder merge rollup, bug 792188.  This patch is about code organization so I don't think any specific test is needed.

Our ToDos and planning are mostly being done on mail/wiki now so this list is out-of-date.  Here are some bugs that fixed some of the things on this list:

Bug 798873 - dynamically allocate space for SDP
Bug 776682 - replace strcpy
Bug 785109 - replace strcat
Bug 784519 - enforce state transition rules