Closed
Bug 781766
Opened 12 years ago
Closed 12 years ago
SIPCC ToDo List
Categories
(Core :: WebRTC: Signaling, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: emannion, Assigned: ehugg)
Details
(Whiteboard: [WebRTC], [blocking-webrtc+], [qa-])
Attachments
(1 file)
26.07 KB,
patch
|
snandaku
:
feedback+
|
Details | Diff | Splinter Review |
All this work will have to be done keeping in mind not to break the existing SIP Stack. Do this using the SDPMode config item. -Use GSM State machine to ensure correct ordering of JSEP calls and report when calls are made in the wrong order. -Dynamically allocate SDP strings when passed in from the API. -Maybe block JSEP API's until SIPCC is started or report error until its started. -Remove any warnings from SIPCC code on all platforms. -Remove network interface enumeration code from PeerConnectionCtx. -Fix some memory leaks. - AddStream and RemoveStream handle multiple tracks - Improve JSEP error handling, either send to logging or implement new callbacks mechanism to send to surface. - Remove much code under ./src/media such as WebRrcAudioProvider and WebRtcVideoProvider etc. - remove NO_WEBRTC_VIDEO from code - prevent calls to timers when in SDPMode: autoAnswerTimer, revertTimer, err_onhook_tmr, maybe a few more - There are other extensions to SDP to be added. - Handle adding multiple streams and tracks. - Remove other unused code, some in plat folders is not used. Still some code around the config_parser that is unused.
Assignee | ||
Comment 1•12 years ago
|
||
- double-check all instances of strcpy, strcat, strncpy, strncat to ensure that they do not overwrite their bounds and null-term strings. Replace most with sstrncpy and sstrncat. - check all instances of memcpy and memmove for possible overwrites. - Eliminate duplicate code in cpr, especially between linux/darwin. - Eliminate most of cpr, replace os-specific functions with one matching function that uses nspr. - Move signaling/media-conduit under signaling/src - Update so it builds on Android and B2G.
Assignee | ||
Comment 2•12 years ago
|
||
Assignee | ||
Updated•12 years ago
|
Attachment #651467 -
Flags: feedback?(snandaku)
Attachment #651467 -
Flags: feedback?(snandaku) → feedback+
Updated•12 years ago
|
Whiteboard: [WebRTC], [blocking-webrtc+]
Assignee | ||
Updated•12 years ago
|
Assignee: emannion → ethanhugg
Assignee | ||
Comment 3•12 years ago
|
||
I'm going to mark this as resolved-fixed. The patch that is here landed on M-C in the alder merge rollup, bug 792188. This patch is about code organization so I don't think any specific test is needed. Our ToDos and planning are mostly being done on mail/wiki now so this list is out-of-date. Here are some bugs that fixed some of the things on this list: Bug 798873 - dynamically allocate space for SDP Bug 776682 - replace strcpy Bug 785109 - replace strcat Bug 784519 - enforce state transition rules
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Updated•12 years ago
|
Whiteboard: [WebRTC], [blocking-webrtc+] → [WebRTC], [blocking-webrtc+], [qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•