Closed
Bug 781773
Opened 14 years ago
Closed 14 years ago
nsLocalFileWin.cpp clean up
Categories
(Core :: XPCOM, defect)
Tracking
()
RESOLVED
FIXED
mozilla17
People
(Reporter: jacek, Assigned: jacek)
Details
Attachments
(1 file)
|
6.08 KB,
patch
|
bbondy
:
review+
|
Details | Diff | Splinter Review |
It's just a clean up found by GCC warnings on mingw compilation:
- don't redefine COPY_FILE_NO_BUFFERING if it's already defined by system headers
- get rid of mingw hack that's fixed upstream (and older mingw versions won't work with recent m-c anyways)
- NULL as 0
- -Wreorder
- unused len variable
- missing MOZ_FIINAL
- access to uninitialized variable (this seems like GCC is wrong about more being accessed uninitialized, but silencing the warning won't hurt)
Attachment #650850 -
Flags: review?(benjamin)
|
||
Updated•14 years ago
|
Attachment #650850 -
Flags: review?(benjamin) → review?(netzen)
|
||
Comment 1•14 years ago
|
||
Comment on attachment 650850 [details] [diff] [review]
patch
Review of attachment 650850 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good, thanks for the patch!
Attachment #650850 -
Flags: review?(netzen) → review+
|
Assignee | |
Comment 2•14 years ago
|
||
Assignee: nobody → jacek
|
||
Comment 3•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in
before you can comment on or make changes to this bug.
Description
•