The default bug view has changed. See this FAQ.

nsLocalFileWin.cpp clean up

RESOLVED FIXED in mozilla17

Status

()

Core
XPCOM
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Jacek Caban, Assigned: Jacek Caban)

Tracking

Trunk
mozilla17
x86_64
Windows 7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 650850 [details] [diff] [review]
patch

It's just a clean up found by GCC warnings on mingw compilation:

- don't redefine COPY_FILE_NO_BUFFERING if it's already defined by system headers
- get rid of mingw hack that's fixed upstream (and older mingw versions won't work with recent m-c anyways)
- NULL as 0
- -Wreorder
- unused len variable
- missing MOZ_FIINAL
- access to uninitialized variable (this seems like GCC is wrong about more being accessed uninitialized, but silencing the warning won't hurt)
Attachment #650850 - Flags: review?(benjamin)
Attachment #650850 - Flags: review?(benjamin) → review?(netzen)
Comment on attachment 650850 [details] [diff] [review]
patch

Review of attachment 650850 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks for the patch!
Attachment #650850 - Flags: review?(netzen) → review+
(Assignee)

Comment 2

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/226e3ed31f87
Assignee: nobody → jacek
https://hg.mozilla.org/mozilla-central/rev/226e3ed31f87
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in before you can comment on or make changes to this bug.