Last Comment Bug 781773 - nsLocalFileWin.cpp clean up
: nsLocalFileWin.cpp clean up
Product: Core
Classification: Components
Component: XPCOM (show other bugs)
: Trunk
: x86_64 Windows 7
-- normal (vote)
: mozilla17
Assigned To: Jacek Caban
: Nathan Froyd [:froydnj]
Depends on:
  Show dependency treegraph
Reported: 2012-08-10 04:48 PDT by Jacek Caban
Modified: 2012-08-14 17:53 PDT (History)
2 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

patch (6.08 KB, patch)
2012-08-10 04:48 PDT, Jacek Caban
netzen: review+
Details | Diff | Splinter Review

Description User image Jacek Caban 2012-08-10 04:48:31 PDT
Created attachment 650850 [details] [diff] [review]

It's just a clean up found by GCC warnings on mingw compilation:

- don't redefine COPY_FILE_NO_BUFFERING if it's already defined by system headers
- get rid of mingw hack that's fixed upstream (and older mingw versions won't work with recent m-c anyways)
- NULL as 0
- -Wreorder
- unused len variable
- missing MOZ_FIINAL
- access to uninitialized variable (this seems like GCC is wrong about more being accessed uninitialized, but silencing the warning won't hurt)
Comment 1 User image Brian R. Bondy [:bbondy] 2012-08-13 10:40:02 PDT
Comment on attachment 650850 [details] [diff] [review]

Review of attachment 650850 [details] [diff] [review]:

Looks good, thanks for the patch!
Comment 3 User image Ryan VanderMeulen [:RyanVM] 2012-08-14 17:53:22 PDT

Note You need to log in before you can comment on or make changes to this bug.