Note: There are a few cases of duplicates in user autocompletion which are being worked on.

[PATCH] make install fails on platforms with PYTHONDONTWRITEBYTECODE

RESOLVED FIXED in Firefox 17

Status

()

Firefox
Build Config
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Shlomi Fish, Assigned: Shlomi Fish)

Tracking

Trunk
Firefox 17
x86_64
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 650881 [details] [diff] [review]
Patch against the Mercurial head to correct the problem - adds "-f" to rm.

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20100101 Firefox/14.0.1
Build ID: 20120806062253

Steps to reproduce:

I built firefox from source using this .mozconfig:

. $topsrcdir/browser/config/mozconfig
export LDFLAGS="-Wl,--no-keep-memory"
mk_add_options MOZ_OBJDIR=@TOPSRCDIR@/ff-dbg
ac_add_options --disable-optimize
ac_add_options --enable-debug
ac_add_options --enable-tests
ac_add_options --enable-debug-symbols
ac_add_options --prefix="/opt/firefox/hg"

On my system I have export PYTHONDONTWRITEBYTECODE=1


Actual results:

I'm getting:

/home/shlomif/Download/unpack/firefox/mozilla-central/ff-dbg/config/nsinstall -D /opt/firefox/hg/lib/firefox-devel-17.0a1/sdk/bin
if test -f ../../dist/include/xpcom-config.h; then \
  /home/shlomif/Download/unpack/firefox/mozilla-central/ff-dbg/config/nsinstall -t -m 644 ../../dist/include/xpcom-config.h /opt/firefox/hg/lib/firefox-devel-17.0a1; \
fi
find ../../dist/sdk -name "*.pyc" | xargs rm
rm: missing operand
Try 'rm --help' for more information.
make[2]: *** [install] Error 123
make[2]: Leaving directory `/home/shlomif/Download/unpack/firefox/mozilla-central/ff-dbg/browser/installer'
make[1]: *** [install] Error 2
make[1]: Leaving directory `/home/shlomif/Download/unpack/firefox/mozilla-central/ff-dbg'
make: *** [install] Error 2



Expected results:

The installation should have proceeded.
(Assignee)

Comment 1

5 years ago
Hi all,

any news regarding this patch? Is there anything else you need from me?

Regards,

-- Shlomi Fish

Updated

5 years ago
Component: Untriaged → Build Config

Comment 2

5 years ago
https://developer.mozilla.org/en-US/docs/Developer_Guide/How_to_Submit_a_Patch#Getting_reviews
Assignee: nobody → shlomif
Attachment #650881 - Flags: review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/f390e36c7fe2
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
https://hg.mozilla.org/mozilla-central/rev/f390e36c7fe2
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 17
(Assignee)

Comment 5

5 years ago
(In reply to Ryan VanderMeulen from comment #4)
> https://hg.mozilla.org/mozilla-central/rev/f390e36c7fe2

Thanks for applying my patch.

Regards,

-- Shlomi Fish

Comment 6

5 years ago
Same bug reported for Fx 15: bug 786349.
You need to log in before you can comment on or make changes to this bug.