Last Comment Bug 781808 - [PATCH] make install fails on platforms with PYTHONDONTWRITEBYTECODE
: [PATCH] make install fails on platforms with PYTHONDONTWRITEBYTECODE
Product: Firefox
Classification: Client Software
Component: Build Config (show other bugs)
: Trunk
: x86_64 Linux
-- normal (vote)
: Firefox 17
Assigned To: Shlomi Fish
: Gregory Szorc [:gps] (away until 2017-03-20)
Depends on:
  Show dependency treegraph
Reported: 2012-08-10 07:55 PDT by Shlomi Fish
Modified: 2012-08-29 10:10 PDT (History)
2 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

Patch against the Mercurial head to correct the problem - adds "-f" to rm. (1.24 KB, patch)
2012-08-10 07:55 PDT, Shlomi Fish
mh+mozilla: review+
Details | Diff | Splinter Review

Description User image Shlomi Fish 2012-08-10 07:55:30 PDT
Created attachment 650881 [details] [diff] [review]
Patch against the Mercurial head to correct the problem - adds "-f" to rm.

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20100101 Firefox/14.0.1
Build ID: 20120806062253

Steps to reproduce:

I built firefox from source using this .mozconfig:

. $topsrcdir/browser/config/mozconfig
export LDFLAGS="-Wl,--no-keep-memory"
mk_add_options MOZ_OBJDIR=@TOPSRCDIR@/ff-dbg
ac_add_options --disable-optimize
ac_add_options --enable-debug
ac_add_options --enable-tests
ac_add_options --enable-debug-symbols
ac_add_options --prefix="/opt/firefox/hg"

On my system I have export PYTHONDONTWRITEBYTECODE=1

Actual results:

I'm getting:

/home/shlomif/Download/unpack/firefox/mozilla-central/ff-dbg/config/nsinstall -D /opt/firefox/hg/lib/firefox-devel-17.0a1/sdk/bin
if test -f ../../dist/include/xpcom-config.h; then \
  /home/shlomif/Download/unpack/firefox/mozilla-central/ff-dbg/config/nsinstall -t -m 644 ../../dist/include/xpcom-config.h /opt/firefox/hg/lib/firefox-devel-17.0a1; \
find ../../dist/sdk -name "*.pyc" | xargs rm
rm: missing operand
Try 'rm --help' for more information.
make[2]: *** [install] Error 123
make[2]: Leaving directory `/home/shlomif/Download/unpack/firefox/mozilla-central/ff-dbg/browser/installer'
make[1]: *** [install] Error 2
make[1]: Leaving directory `/home/shlomif/Download/unpack/firefox/mozilla-central/ff-dbg'
make: *** [install] Error 2

Expected results:

The installation should have proceeded.
Comment 1 User image Shlomi Fish 2012-08-17 10:21:18 PDT
Hi all,

any news regarding this patch? Is there anything else you need from me?


-- Shlomi Fish
Comment 4 User image Ryan VanderMeulen [:RyanVM] 2012-08-18 16:19:43 PDT
Comment 5 User image Shlomi Fish 2012-08-19 00:43:23 PDT
(In reply to Ryan VanderMeulen from comment #4)

Thanks for applying my patch.


-- Shlomi Fish
Comment 6 User image [:Aleksej] 2012-08-29 10:10:59 PDT
Same bug reported for Fx 15: bug 786349.

Note You need to log in before you can comment on or make changes to this bug.