GCLI should support 'then-able' promises instead of checking d.isPromise (#58)

RESOLVED FIXED in Firefox 17

Status

P3
normal
RESOLVED FIXED
7 years ago
7 months ago

People

(Reporter: jwalker, Unassigned)

Tracking

unspecified
Firefox 17

Firefox Tracking Flags

(Not tracked)

Details

In cli.js (around line 1075) the check on the return type for a promise is currently ...

 if (reply != null && reply.isPromise)

This is fine for the built-in context.createPromise() but could be made to work with all then-able promises by using...

 if (reply && typeof reply.then === 'function')

---
See also
https://github.com/mozilla/gcli/issues/58
Priority: -- → P3
Target Milestone: --- → Firefox 17
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED

Updated

7 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.