As a security precaution, we have turned on the setting "Require API key authentication for API requests" for everyone. If this has broken something, please contact
Last Comment Bug 781869 - nsHTMLScrollFrame::ReflowScrolledFrame() redundantly passes NS_FRAME_NO_MOVE_VIEW with NS_FRAME_NO_MOVE_FRAME (which already includes the _VIEW bit)
: nsHTMLScrollFrame::ReflowScrolledFrame() redundantly passes NS_FRAME_NO_MOVE_...
Product: Core
Classification: Components
Component: Layout (show other bugs)
: Trunk
: All All
: -- trivial (vote)
: mozilla17
Assigned To: Daniel Holbert [:dholbert]
: Jet Villegas (:jet)
Depends on:
  Show dependency treegraph
Reported: 2012-08-10 11:02 PDT by Daniel Holbert [:dholbert]
Modified: 2012-08-17 19:22 PDT (History)
1 user (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

fix (2.26 KB, patch)
2012-08-10 14:50 PDT, Daniel Holbert [:dholbert]
dbaron: review+
Details | Diff | Splinter Review

Description User image Daniel Holbert [:dholbert] 2012-08-10 11:02:09 PDT
nsHTMLScrollFrame::ReflowScrolledFrame() has two places where it passes:  

The _VIEW bit there is redundant, because NS_FRAME_NO_MOVE_FRAME is defined to already include it:
> 19 #define NS_FRAME_NO_MOVE_FRAME        (0x0002 | NS_FRAME_NO_MOVE_VIEW)

So, I think we can just drop the "| NS_FRAME_NO_MOVE_VIEW" in these instances.
Comment 1 User image Daniel Holbert [:dholbert] 2012-08-10 14:50:22 PDT
Created attachment 651006 [details] [diff] [review]
Comment 2 User image David Baron :dbaron: ⌚️UTC-8 2012-08-17 11:52:37 PDT
Comment on attachment 651006 [details] [diff] [review]

Comment 3 User image Daniel Holbert [:dholbert] 2012-08-17 12:09:14 PDT
Comment 4 User image Ryan VanderMeulen [:RyanVM] 2012-08-17 19:22:29 PDT

Note You need to log in before you can comment on or make changes to this bug.