Last Comment Bug 781869 - nsHTMLScrollFrame::ReflowScrolledFrame() redundantly passes NS_FRAME_NO_MOVE_VIEW with NS_FRAME_NO_MOVE_FRAME (which already includes the _VIEW bit)
: nsHTMLScrollFrame::ReflowScrolledFrame() redundantly passes NS_FRAME_NO_MOVE_...
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Layout (show other bugs)
: Trunk
: All All
: -- trivial (vote)
: mozilla17
Assigned To: Daniel Holbert [:dholbert] (largely AFK until June 28)
:
Mentors:
http://mxr.mozilla.org/mozilla-centra...
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-08-10 11:02 PDT by Daniel Holbert [:dholbert] (largely AFK until June 28)
Modified: 2012-08-17 19:22 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
fix (2.26 KB, patch)
2012-08-10 14:50 PDT, Daniel Holbert [:dholbert] (largely AFK until June 28)
dbaron: review+
Details | Diff | Review

Description Daniel Holbert [:dholbert] (largely AFK until June 28) 2012-08-10 11:02:09 PDT
nsHTMLScrollFrame::ReflowScrolledFrame() has two places where it passes:  
  NS_FRAME_NO_MOVE_FRAME | NS_FRAME_NO_MOVE_VIEW

The _VIEW bit there is redundant, because NS_FRAME_NO_MOVE_FRAME is defined to already include it:
> 19 #define NS_FRAME_NO_MOVE_FRAME        (0x0002 | NS_FRAME_NO_MOVE_VIEW)
http://mxr.mozilla.org/mozilla-central/source/layout/generic/nsContainerFrame.h#19

So, I think we can just drop the "| NS_FRAME_NO_MOVE_VIEW" in these instances.
Comment 1 Daniel Holbert [:dholbert] (largely AFK until June 28) 2012-08-10 14:50:22 PDT
Created attachment 651006 [details] [diff] [review]
fix
Comment 2 David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch) 2012-08-17 11:52:37 PDT
Comment on attachment 651006 [details] [diff] [review]
fix

r=dbaron
Comment 3 Daniel Holbert [:dholbert] (largely AFK until June 28) 2012-08-17 12:09:14 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/9556e43af1be
Comment 4 Ryan VanderMeulen [:RyanVM] 2012-08-17 19:22:29 PDT
https://hg.mozilla.org/mozilla-central/rev/9556e43af1be

Note You need to log in before you can comment on or make changes to this bug.