nsHTMLScrollFrame::ReflowScrolledFrame() redundantly passes NS_FRAME_NO_MOVE_VIEW with NS_FRAME_NO_MOVE_FRAME (which already includes the _VIEW bit)

RESOLVED FIXED in mozilla17

Status

()

Core
Layout
--
trivial
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: dholbert, Assigned: dholbert)

Tracking

Trunk
mozilla17
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
nsHTMLScrollFrame::ReflowScrolledFrame() has two places where it passes:  
  NS_FRAME_NO_MOVE_FRAME | NS_FRAME_NO_MOVE_VIEW

The _VIEW bit there is redundant, because NS_FRAME_NO_MOVE_FRAME is defined to already include it:
> 19 #define NS_FRAME_NO_MOVE_FRAME        (0x0002 | NS_FRAME_NO_MOVE_VIEW)
http://mxr.mozilla.org/mozilla-central/source/layout/generic/nsContainerFrame.h#19

So, I think we can just drop the "| NS_FRAME_NO_MOVE_VIEW" in these instances.
(Assignee)

Comment 1

5 years ago
Created attachment 651006 [details] [diff] [review]
fix
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Attachment #651006 - Flags: review?(dbaron)
Comment on attachment 651006 [details] [diff] [review]
fix

r=dbaron
Attachment #651006 - Flags: review?(dbaron) → review+
(Assignee)

Comment 3

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/9556e43af1be
https://hg.mozilla.org/mozilla-central/rev/9556e43af1be
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in before you can comment on or make changes to this bug.