Closed
Bug 781891
Opened 13 years ago
Closed 13 years ago
l10n_slaves cannot be overridden
Categories
(Release Engineering :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jhopkins, Assigned: jhopkins)
Details
Attachments
(1 file)
|
1.61 KB,
patch
|
rail
:
review+
jhopkins
:
checked-in+
|
Details | Diff | Splinter Review |
While trying to set l10n_slaves in mozilla-inbound, I noticed that our automation does not allow that since it doesn't check whether l10n_slaves is already set before setting that value:
https://hg.mozilla.org/build/buildbot-configs/file/8fea6fabd400/mozilla/builder_master.cfg#l65
|
Assignee | |
Comment 1•13 years ago
|
||
Tested that this patch passes setup-master.py tests for all masters, that dump_masters.sh output is the same before and after the patch, and a change to l10n_slaves in the mozilla-inbound project branch takes effect with this patch applied.
Attachment #650981 -
Flags: review?(rail)
|
|
||
Comment 2•13 years ago
|
||
Comment on attachment 650981 [details] [diff] [review]
proposed buildbot-configs patch
lgtm
Attachment #650981 -
Flags: review?(rail) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
Comment on attachment 650981 [details] [diff] [review]
proposed buildbot-configs patch
Landed in https://hg.mozilla.org/build/buildbot-configs/rev/82683039a46f
Attachment #650981 -
Flags: checked-in+
|
|
||
Comment 4•13 years ago
|
||
In production since yesterday.
|
|
Assignee | |
Updated•13 years ago
|
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
||
Updated•12 years ago
|
Product: mozilla.org → Release Engineering
You need to log in
before you can comment on or make changes to this bug.
Description
•