The default bug view has changed. See this FAQ.

<wizard/> : Using advance(pageId) on the last page should not close the wizard

RESOLVED FIXED in mozilla17

Status

()

Core
XUL
--
minor
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: wnayes, Assigned: wnayes)

Tracking

(Blocks: 1 bug)

Trunk
mozilla17
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
I was trying to use advance() with a page ID parameter on the last page to send the user to a previous page. The use of goTo() is not a desired alternative, as it does not properly handle the page stack and makes the Back/Next buttons unreliable.

Expected: The wizard would jump to the page ID specified as an argument to advance().

Result: The wizard calls the method in "wizardfinish" and closes.

I believe a fix could be done with a single change at
http://mxr.mozilla.org/mozilla-central/source/toolkit/content/widgets/wizard.xml#270
The existence of aPageId should also be checked with onLastPage to ensure that the wizard is really ready to finish and close.

I am new to patching Mozilla, so I may or may not be successful in creating one myself.
(Assignee)

Comment 1

5 years ago
Created attachment 651022 [details] [diff] [review]
Add a check for aPageId before closing the wizard

This adds a check to ensure that there is no page ID before closing the wizard when advancing backwards on the last page.
Attachment #651022 - Flags: review?
(Assignee)

Updated

5 years ago
Blocks: 596002
Attachment #651022 - Flags: review? → review?(enndeakin)

Comment 2

5 years ago
Comment on attachment 651022 [details] [diff] [review]
Add a check for aPageId before closing the wizard

Thanks for the patch. I assume you don't have permission to check the patch in. In this case, you can set the 'checkin-needed' keyword on the bug and someone will check it in for you.
Attachment #651022 - Flags: review?(enndeakin) → review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
Trivial enough to land without a Try push. Thanks for the patch, Will! You can confirm that this bug is fixed once it lands on mozilla-central (probably tomorrow morning).

https://hg.mozilla.org/integration/mozilla-inbound/rev/636c283ed0ed
Assignee: nobody → wnayes
Flags: in-testsuite-
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/636c283ed0ed
Status: UNCONFIRMED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in before you can comment on or make changes to this bug.