IonMonkey: visitCallDOMNative() must dropArguments()

RESOLVED FIXED

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: sstangl, Assigned: sstangl)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [ion:p1], URL)

Attachments

(2 attachments)

(Assignee)

Description

5 years ago
Created attachment 651059 [details]
Backtrace.

Asserts in an x86_64 Ion debug browser by visiting http://lights.elliegoulding.com, waiting for it to load, and clicking "Play".

The problem is most likely that visitCallDOMNative() is missing a call to dropArguments().

Backtrace attached.
(Assignee)

Comment 1

5 years ago
Created attachment 651065 [details] [diff] [review]
patch

Fixes crash. Site runs happily if jankily.
Attachment #651065 - Flags: review?(efaust)
(Assignee)

Updated

5 years ago
Summary: IonMonkey: Assertion Failure: pushArgumentSlots_.empty() in CodeGenerator.cpp:1244 → IonMonkey: visitCallDOMNative() must dropArguments()

Updated

5 years ago
Attachment #651065 - Flags: review?(efaust) → review+
(Assignee)

Comment 2

5 years ago
http://hg.mozilla.org/projects/ionmonkey/rev/32b7b76d111c
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.