Closed Bug 782018 Opened 8 years ago Closed 8 years ago

Duplicate accesskey A in MailNews View menu

Categories

(SeaMonkey :: MailNews: General, defect)

defect
Not set
trivial

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.14

People

(Reporter: InvisibleSmiley, Assigned: InvisibleSmiley)

References

Details

Attachments

(1 file)

Display Attachment Inline and Apply Theme share the same accesskey (A). Since the latter is defined using an overlay and also used in the browser, I'd like to change the accesskey of the former.

Proposed new accesskey: D
Attachment #651104 - Flags: review?(neil)
I think Karsten would be a more appropriate reviewer.
Attachment #651104 - Flags: review?(neil) → review+
Comment on attachment 651104 [details] [diff] [review]
patch [Checkin: Comment 2]

http://hg.mozilla.org/comm-central/rev/e13700a97e92
Attachment #651104 - Attachment description: patch → patch [Checkin: Comment 2]
(In reply to Philip Chee from comment #1)
> I think Karsten would be a more appropriate reviewer.

I think it is perfectly valid to request review from someone who is
* our UI tsar
* a MailNews peer (= allowed to review any MailNews code)
* the Browser owner
* the Cross-suite components owner
don't you think? ;-)

I especially had in mind that Neil (and Ian) has repeatedly been involved in accesskey discussions, and the alternative to changing the Display Attachments Inline accesskey would have been to change the Apply Themes one, which would have touched Browser/Cross-suite components.
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.14
You need to log in before you can comment on or make changes to this bug.