78202 - getComputedStyle not implemented for text-decoration property

Status: VERIFIED FIXED

(Core :: DOM: CSS Object Model, defect)

Description

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

getComputedStyle DOM 2 Style is not implemented for text-decoration property.
The answer is always "".

This is needed for the CSSization of Composer.

Comment 1

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Attachment: test case showing bug ; click on the link

Comment 2

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

adding dependency : blocking 77705

Comment 3

[harishd]

Attachment: Patch v1.1

Comment 4

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

I have a question related to your patch :

+  
+  if(text) {
+    const nsCString& decoration=
+     
nsCSSProps::SearchKeywordTable(text->mTextDecoration,nsCSSProps::kTextDecorationKTable);
+    val->SetString(decoration);
+  }
+  else {
+    val->SetString("");
+  }

What means here a "" return string ?
Empty value is not a valid value for text-decoration. What does it mean ?
If it means 'equal to the initial value because the property is not inherited
and no specific value is assigned', I suggest you use the value "none" for
fallback instead of "".
Using the initial value should also be the fallback for all other properties.

Cc:ing Hixie because I would like to read his opinion.

Comment 5

[Hixie (not reading bugmail)]

I don't have a particular opinion. The result of GetComputedStyle for text-
decoration is quite well defined, and will be one of the following strings:

   "none"                           
   "underline"                       "overline"
   "line-through"                    "blink"
   "underline overline"              "underline line-through"
   "underline blink"                 "overline line-through" 
   "overline blink"                  "line-through blink"
   "underline overline line-through" "underline overline blink"
   "underline line-through blink"    "overline line-through blink"

Note that the CSS3 text module will change this. In CSS3, "" will be a valid 
response for GetComputedStyle.textDecoration. It will represent the cases that
do not map to the text-decoration shorthand (this is similar to how "border"
can be "" for some cases).

Comment 6

[harishd]

heikki says r=heikki

Comment 7

[Johnny Stenback (:jst)]

Daniel, you'd only get "" in an error case if the style system screws up, you'll
get default values n' all that from the style system.

sr=jst

Comment 8

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

aaaahhh, ok, thanks jst

Comment 9

[harishd]

Fix is in. Marking FIXED.

Comment 10

[Hixie (not reading bugmail)]

VERIFIED per http://bugzilla.mozilla.org/showattachment.cgi?attach_id=32625