782037 - No global method depfinished in data.py

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[[e-mail]]

def _startdepparallel(self, d):
    if self.makefile.error:
        depfinished(True, False)

Comment 1

[Ian Melven :imelven]

I'm seeing this as well - using pymake on Windows and current m-c.

Comment 2

[Ian Melven :imelven]

This reproduced for me after i blew away my objdir and rebuilt from scratch - but then after doing that again - it no longer does :/

Comment 3

[Ian Melven :imelven]

I spoke too soon, i just hit it again :

Traceback (most recent call last):
  File "build/pymake/make.py", line 18, in <module>
    pymake.process.ParallelContext.spin()
  File "c:\Users\imelven\src\mozilla\build\pymake\pymake\process.py", line 352,
in spin
    c.run()
  File "c:\Users\imelven\src\mozilla\build\pymake\pymake\process.py", line 282,
in run
    cb(*args, **kwargs)
  File "c:\Users\imelven\src\mozilla\build\pymake\pymake\data.py", line 841, in
_startdepparallel
    depfinished(True, False)
NameError: global name 'depfinished' is not defined

Comment 4

[Ian Melven :imelven]

ok, this does look like an issue that happens when there's an error in the build - the error in the build seems to be my fault from the local changes :(

Comment 5

[Ziga Seilnacht]

Attachment: fix NameError with missing `depfinished` function when there is a makefile error

I hit this bug while working on bug 874210, and it is annoying because it hides the underlying error. Just now, someone hit it on the UX branch:

https://tbpl.mozilla.org/php/getParsedLog.php?id=30245077&tree=UX#error0

The attached patch does what seems to be the correct action here, but someone with better pymake understanding should check that it is correct.

Comment 6

[Ziga Seilnacht]

Attachment: [gecko] fix NameError with missing `depfinished` function (for checkin)

Comment 7

[Ziga Seilnacht]

Attachment: [pymake] fix NameError with missing `depfinished` function (for checkin)

Could someone please check these two pathes in for me, or set the checkin-needed flag.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ac5cd57bbd04
https://hg.mozilla.org/users/bsmedberg_mozilla.com/pymake/rev/87a4f61ed5fe

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ac5cd57bbd04