The default bug view has changed. See this FAQ.

Get rid of the fullscreencontrol attribute

RESOLVED FIXED in Firefox 17

Status

()

Firefox
Toolbars and Customization
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: dao, Assigned: dao)

Tracking

Trunk
Firefox 17
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
We used to have multiple elements with the fullscreencontrol attribute set, but bug 739093 changed this. We can just show/hide #window-controls directly.
(Assignee)

Comment 1

5 years ago
Created attachment 651131 [details] [diff] [review]
patch
Attachment #651131 - Flags: review?(felipc)
Comment on attachment 651131 [details] [diff] [review]
patch

Review of attachment 651131 [details] [diff] [review]:
-----------------------------------------------------------------

The change looks fine to me. I took a look through add-ons on MXR and this seems rarely used. From the ones that use fullscreencontrol=true, it's just overlaying the same window-controls element, so it will be no problem. There's one though that uses fullscreencontrol=false (foxiFrame), but it's not marked as compatible with recent versions of Firefox
Attachment #651131 - Flags: review?(felipc) → review+
(Assignee)

Comment 3

5 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/303b75594832
https://hg.mozilla.org/mozilla-central/rev/303b75594832
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 17
You need to log in before you can comment on or make changes to this bug.