Closed
Bug 782043
Opened 14 years ago
Closed 14 years ago
Get rid of the fullscreencontrol attribute
Categories
(Firefox :: Toolbars and Customization, defect)
Firefox
Toolbars and Customization
Tracking
()
RESOLVED
FIXED
Firefox 17
People
(Reporter: dao, Assigned: dao)
References
Details
Attachments
(1 file)
|
2.01 KB,
patch
|
Felipe
:
review+
|
Details | Diff | Splinter Review |
We used to have multiple elements with the fullscreencontrol attribute set, but bug 739093 changed this. We can just show/hide #window-controls directly.
|
Assignee | |
Comment 1•14 years ago
|
||
Attachment #651131 -
Flags: review?(felipc)
|
||
Comment 2•14 years ago
|
||
Comment on attachment 651131 [details] [diff] [review]
patch
Review of attachment 651131 [details] [diff] [review]:
-----------------------------------------------------------------
The change looks fine to me. I took a look through add-ons on MXR and this seems rarely used. From the ones that use fullscreencontrol=true, it's just overlaying the same window-controls element, so it will be no problem. There's one though that uses fullscreencontrol=false (foxiFrame), but it's not marked as compatible with recent versions of Firefox
Attachment #651131 -
Flags: review?(felipc) → review+
|
|
Assignee | |
Comment 3•14 years ago
|
||
|
||
Comment 4•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 17
You need to log in
before you can comment on or make changes to this bug.
Description
•