Last Comment Bug 782043 - Get rid of the fullscreencontrol attribute
: Get rid of the fullscreencontrol attribute
Status: RESOLVED FIXED
:
Product: Firefox
Classification: Client Software
Component: Toolbars and Customization (show other bugs)
: Trunk
: All All
: -- normal (vote)
: Firefox 17
Assigned To: Dão Gottwald [:dao]
:
: :Gijs Kruitbosch
Mentors:
Depends on: 739093
Blocks:
  Show dependency treegraph
 
Reported: 2012-08-11 07:54 PDT by Dão Gottwald [:dao]
Modified: 2012-08-14 05:59 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (2.01 KB, patch)
2012-08-11 10:05 PDT, Dão Gottwald [:dao]
felipc: review+
Details | Diff | Splinter Review

Description Dão Gottwald [:dao] 2012-08-11 07:54:48 PDT
We used to have multiple elements with the fullscreencontrol attribute set, but bug 739093 changed this. We can just show/hide #window-controls directly.
Comment 1 Dão Gottwald [:dao] 2012-08-11 10:05:20 PDT
Created attachment 651131 [details] [diff] [review]
patch
Comment 2 :Felipe Gomes (needinfo me!) 2012-08-13 18:08:43 PDT
Comment on attachment 651131 [details] [diff] [review]
patch

Review of attachment 651131 [details] [diff] [review]:
-----------------------------------------------------------------

The change looks fine to me. I took a look through add-ons on MXR and this seems rarely used. From the ones that use fullscreencontrol=true, it's just overlaying the same window-controls element, so it will be no problem. There's one though that uses fullscreencontrol=false (foxiFrame), but it's not marked as compatible with recent versions of Firefox
Comment 4 Ed Morley [:emorley] 2012-08-14 05:59:24 PDT
https://hg.mozilla.org/mozilla-central/rev/303b75594832

Note You need to log in before you can comment on or make changes to this bug.