Note: There are a few cases of duplicates in user autocompletion which are being worked on.

IonMonkey: Assertion failure: [infer failure] Missing type pushed 0: float, at jsinfer.cpp:327

RESOLVED FIXED

Status

()

Core
JavaScript Engine
--
major
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: decoder, Assigned: dvander)

Tracking

(Blocks: 2 bugs, {assertion, testcase})

Other Branch
x86_64
Linux
assertion, testcase
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [jsbugmon:update][ion:p1:fx18])

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

5 years ago
The following testcase asserts on ionmonkey revision f1764bf06b29 (run with --ion -n):


test();
function test() {
    var n = 1000000;
    var start = new Date();
    var mceil = Math.floor;
    for (i = 3; i<= n; i+=2) {}
    var end = mceil  ();
    var timetaken = end - start;
    timetaken = timetaken / 1000;
    return timetaken;
}
(Assignee)

Updated

5 years ago
Whiteboard: [jsbugmon:update] → [jsbugmon:update][ion:p1:fx18]
(Assignee)

Comment 1

5 years ago
Created attachment 651900 [details] [diff] [review]
fix

The bug is that "double" may not be in the typeset for a call's return value, but we aggressively fold Math.floor() and friends to return a NaN. This patch just removes all this folding since it doesn't appear to occur in benchmarks anyway.
Assignee: general → dvander
Status: NEW → ASSIGNED
Attachment #651900 - Flags: review?(sstangl)
(Assignee)

Comment 2

5 years ago
Created attachment 651903 [details] [diff] [review]
with typo fixed
Attachment #651900 - Attachment is obsolete: true
Attachment #651900 - Flags: review?(sstangl)
Attachment #651903 - Flags: review?
Comment on attachment 651903 [details] [diff] [review]
with typo fixed

Review of attachment 651903 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/ion/MCallOptimize.cpp
@@ +426,5 @@
>      if (constructing)
>          return InliningStatus_NotInlined;
>  
> +    if (argc != 2)
> +        return InliningStatus_NotInlined;

This can be "< 2".
Attachment #651903 - Flags: review? → review+
(Assignee)

Comment 4

5 years ago
I kept != 2 to be strict about what we accept as optimizable.

https://hg.mozilla.org/projects/ionmonkey/rev/6a707a112b58
Group: core-security
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(Reporter)

Comment 5

5 years ago
A testcase for this bug was automatically identified at js/src/jit-test/tests/ion/bug782087.js.
Flags: in-testsuite+
You need to log in before you can comment on or make changes to this bug.