Last Comment Bug 782175 - delta_multiplier_(x|y|z) should support less than 100 value and larger than -100 value
: delta_multiplier_(x|y|z) should support less than 100 value and larger than -...
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Event Handling (show other bugs)
: Trunk
: All All
: -- enhancement (vote)
: mozilla17
Assigned To: Masayuki Nakano [:masayuki] (Mozilla Japan)
:
Mentors:
Depends on:
Blocks: 719320 782143
  Show dependency treegraph
 
Reported: 2012-08-12 20:59 PDT by Masayuki Nakano [:masayuki] (Mozilla Japan)
Modified: 2012-08-17 22:18 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (10.75 KB, patch)
2012-08-15 02:55 PDT, Masayuki Nakano [:masayuki] (Mozilla Japan)
no flags Details | Diff | Splinter Review
Patch (10.78 KB, patch)
2012-08-15 22:26 PDT, Masayuki Nakano [:masayuki] (Mozilla Japan)
bugs: review+
Details | Diff | Splinter Review

Description Masayuki Nakano [:masayuki] (Mozilla Japan) 2012-08-12 20:59:44 PDT
delta_multiplier_(x|y|z) prefs don't support < 100 values and > -100 values.

I guess that we need to take additional care fractional delta values of DOM_DELTA_PIXEL.
Comment 1 Masayuki Nakano [:masayuki] (Mozilla Japan) 2012-08-15 02:55:17 PDT
Created attachment 652051 [details] [diff] [review]
Patch
Comment 2 Masayuki Nakano [:masayuki] (Mozilla Japan) 2012-08-15 22:26:46 PDT
Created attachment 652326 [details] [diff] [review]
Patch

The fix for bug 422132 makes this patch simple.

The DeltaAccumulator::mPendingScrollAmount(X|Y) supports scrolling less than 1px. So, this patch just removes the pref value checking and avoiding zero divide.

I think that if all delta values become 0 by the prefs, the wheel event shouldn't cause DOM event.
Comment 3 Masayuki Nakano [:masayuki] (Mozilla Japan) 2012-08-16 18:34:18 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/112f7d84d94b
Comment 4 Ed Morley [:emorley] 2012-08-17 05:28:14 PDT
https://hg.mozilla.org/mozilla-central/rev/112f7d84d94b

Note You need to log in before you can comment on or make changes to this bug.