782175 - delta_multiplier_(x|y|z) should support less than 100 value and larger than -100 value

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, enhancement)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

delta_multiplier_(x|y|z) prefs don't support < 100 values and > -100 values.

I guess that we need to take additional care fractional delta values of DOM_DELTA_PIXEL.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch

The fix for bug 422132 makes this patch simple.

The DeltaAccumulator::mPendingScrollAmount(X|Y) supports scrolling less than 1px. So, this patch just removes the pref value checking and avoiding zero divide.

I think that if all delta values become 0 by the prefs, the wheel event shouldn't cause DOM event.

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/112f7d84d94b

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/112f7d84d94b