Closed Bug 782175 Opened 8 years ago Closed 8 years ago

delta_multiplier_(x|y|z) should support less than 100 value and larger than -100 value

Categories

(Core :: DOM: UI Events & Focus Handling, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla17

People

(Reporter: masayuki, Assigned: masayuki)

References

Details

Attachments

(1 file, 1 obsolete file)

delta_multiplier_(x|y|z) prefs don't support < 100 values and > -100 values.

I guess that we need to take additional care fractional delta values of DOM_DELTA_PIXEL.
Attached patch Patch (obsolete) — Splinter Review
Attached patch PatchSplinter Review
The fix for bug 422132 makes this patch simple.

The DeltaAccumulator::mPendingScrollAmount(X|Y) supports scrolling less than 1px. So, this patch just removes the pref value checking and avoiding zero divide.

I think that if all delta values become 0 by the prefs, the wheel event shouldn't cause DOM event.
Attachment #652051 - Attachment is obsolete: true
Attachment #652326 - Flags: review?(bugs)
Attachment #652326 - Flags: review?(bugs) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/112f7d84d94b
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla17
https://hg.mozilla.org/mozilla-central/rev/112f7d84d94b
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Blocks: 782143
Component: Event Handling → User events and focus handling
You need to log in before you can comment on or make changes to this bug.