delta_multiplier_(x|y|z) should support less than 100 value and larger than -100 value

RESOLVED FIXED in mozilla17

Status

()

Core
Event Handling
--
enhancement
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: masayuki, Assigned: masayuki)

Tracking

Trunk
mozilla17
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
delta_multiplier_(x|y|z) prefs don't support < 100 values and > -100 values.

I guess that we need to take additional care fractional delta values of DOM_DELTA_PIXEL.
(Assignee)

Comment 1

5 years ago
Created attachment 652051 [details] [diff] [review]
Patch
(Assignee)

Comment 2

5 years ago
Created attachment 652326 [details] [diff] [review]
Patch

The fix for bug 422132 makes this patch simple.

The DeltaAccumulator::mPendingScrollAmount(X|Y) supports scrolling less than 1px. So, this patch just removes the pref value checking and avoiding zero divide.

I think that if all delta values become 0 by the prefs, the wheel event shouldn't cause DOM event.
Attachment #652051 - Attachment is obsolete: true
Attachment #652326 - Flags: review?(bugs)

Updated

5 years ago
Attachment #652326 - Flags: review?(bugs) → review+
(Assignee)

Comment 3

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/112f7d84d94b
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla17

Comment 4

5 years ago
https://hg.mozilla.org/mozilla-central/rev/112f7d84d94b
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED

Updated

5 years ago
Blocks: 782143
You need to log in before you can comment on or make changes to this bug.