782185 - don't use EXTEND_NONE in image layers

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Karl Tomlinson (:karlt)]

When there is a transform, EXTEND_NONE is not what we want, is incorrectly implemented by NVIDIA drivers to extend CONTENT_COLOR surfaces with black, and is slower than EXTEND_PAD with other drivers.

Comment 1

[Karl Tomlinson (:karlt)]

Attachment: provide a gfxXlibSurface method to indicate when cairo's extend_pad will be slow

Comment 2

[Karl Tomlinson (:karlt)]

The only supported free distribution that I know still has one of these old
servers is OpenSUSE 11.2.  It has xorg server 1.6.5 and I understand the
Evergreen community is endeavouring to support this version.  (The oldest
currently supported Debian release is 6.0 squeeze which has xorg-server 1.7.7.
Ubuntu 10.04 LTS has 1.7.6.)

The latest SLES, 11-SP2 also still has only xorg-server 1.6.5.  Their
customers should expect a functional RepeatPad, but unfortunately cairo will
effect the workaround and take the readback path.

Comment 3

[Karl Tomlinson (:karlt)]

Attachment: use extend_pad when compositing image layers even for Quartz and X11

Bug 562746 comment 65 removed use of EXTEND_NONE in gfxDrawable with Quartz
because of changes in the cairo implementation, so I expect the same reasoning
to apply here.

Comment 4

[Karl Tomlinson (:karlt)]

https://tbpl.mozilla.org/?tree=Try&rev=eb69871b1f2e
https://tbpl.mozilla.org/?tree=Try&rev=4ca135c48dfc

https://hg.mozilla.org/integration/mozilla-inbound/rev/48d2889019ed
https://hg.mozilla.org/integration/mozilla-inbound/rev/016e27967434

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/48d2889019ed
https://hg.mozilla.org/mozilla-central/rev/016e27967434