don't use EXTEND_NONE in image layers

RESOLVED FIXED in mozilla17

Status

()

Core
Graphics: Layers
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: karlt, Assigned: karlt)

Tracking

(Blocks: 1 bug)

13 Branch
mozilla17
x86_64
Linux
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

When there is a transform, EXTEND_NONE is not what we want, is incorrectly implemented by NVIDIA drivers to extend CONTENT_COLOR surfaces with black, and is slower than EXTEND_PAD with other drivers.
(Assignee)

Comment 1

5 years ago
Created attachment 651268 [details] [diff] [review]
provide a gfxXlibSurface method to indicate when cairo's extend_pad will be slow
Assignee: nobody → karlt
Status: NEW → ASSIGNED
Attachment #651268 - Flags: review?(joe)
(Assignee)

Comment 2

5 years ago
The only supported free distribution that I know still has one of these old
servers is OpenSUSE 11.2.  It has xorg server 1.6.5 and I understand the
Evergreen community is endeavouring to support this version.  (The oldest
currently supported Debian release is 6.0 squeeze which has xorg-server 1.7.7.
Ubuntu 10.04 LTS has 1.7.6.)

The latest SLES, 11-SP2 also still has only xorg-server 1.6.5.  Their
customers should expect a functional RepeatPad, but unfortunately cairo will
effect the workaround and take the readback path.
(Assignee)

Comment 3

5 years ago
Created attachment 651270 [details] [diff] [review]
use extend_pad when compositing image layers even for Quartz and X11

Bug 562746 comment 65 removed use of EXTEND_NONE in gfxDrawable with Quartz
because of changes in the cairo implementation, so I expect the same reasoning
to apply here.
(Assignee)

Updated

5 years ago
Attachment #651270 - Flags: review?(roc)
Attachment #651270 - Flags: review?(roc) → review+
Attachment #651268 - Flags: review?(joe) → review+
(Assignee)

Comment 4

5 years ago
https://tbpl.mozilla.org/?tree=Try&rev=eb69871b1f2e
https://tbpl.mozilla.org/?tree=Try&rev=4ca135c48dfc

https://hg.mozilla.org/integration/mozilla-inbound/rev/48d2889019ed
https://hg.mozilla.org/integration/mozilla-inbound/rev/016e27967434
Flags: in-testsuite+

Comment 5

5 years ago
https://hg.mozilla.org/mozilla-central/rev/48d2889019ed
https://hg.mozilla.org/mozilla-central/rev/016e27967434
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in before you can comment on or make changes to this bug.