782190 - Implement onwheel attribute

Status: RESOLVED FIXED

(Core :: DOM: Events, enhancement)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

D3E WheelEvent has been implemented already. However, there is no event attribute for it.

HTML5 draft doesn't define onwheel, but defines onmousewheel which is for the legacy mousewheel event (implemented on IE and WebKit). I think that we shouldn't use the name for wheel event and should be dropped from HTML5 spec.

https://www.w3.org/Bugs/Public/show_bug.cgi?id=18542

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Does IE have onwheel?

But anyhow, we should have it.

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

(In reply to Olli Pettay [:smaug] from comment #1)
> Does IE have onwheel?

IE9 doesn't support onwheel event. I don't know IE10. I don't have environment which has IE10.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

you mean IE9 doesn't have onwheel property? It should support "wheel" event, I think.
At least they were claiming to implement all of D3E.

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

(In reply to Olli Pettay [:smaug] from comment #3)
> you mean IE9 doesn't have onwheel property?

Oops, I meant onwheel attribute isn't supported. E.g.,

<div style="overflow: auto; height: 100px; width: 100px;" onwheel="alert(event.type);">
<div style="height: 1000px; width: 1000px;" onwheel="alert(event.type);"></div>
</div>

In this case, these onwheel's script are not performed.

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: testcase

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 651650 [details] [diff] [review]
Patch

I think we want also target.onwheel support, not only <element onwheel>

Comment 8

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Ah, but I don't know where I need to change. Where should I change?

Comment 9

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Oh, in each interface?
http://mxr.mozilla.org/mozilla-central/source/dom/interfaces/base/nsIDOMWindow.idl
http://mxr.mozilla.org/mozilla-central/source/dom/interfaces/core/nsIDOMElement.idl
http://mxr.mozilla.org/mozilla-central/source/dom/interfaces/core/nsIDOMDocument.idl

Comment 10

[Olli Pettay [:smaug][[e-mail]]]

Yup, similarly to, hmm, I guess onclick for example.

Comment 11

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Ah, I got it.
http://mxr.mozilla.org/mozilla-central/source/dom/interfaces/core/nsIInlineEventHandlers.idl

Comment 12

[Olli Pettay [:smaug][[e-mail]]]

You'll need to also use different macro in nsEventNameList.h

Comment 13

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch

Comment 14

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/90b4786131bd

Comment 15

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/90b4786131bd