Push hghooks 8db0fe2a5231 and TBPL a7b02d5b8785 to prod, to get TreeStatus live

RESOLVED FIXED

Status

Developer Services
General
--
major
RESOLVED FIXED
6 years ago
4 years ago

People

(Reporter: emorley, Assigned: bkero)

Tracking

Details

(Reporter)

Description

6 years ago
In order to switch from tinderbox to TreeStatus for controlling the open/closed state of the trees, we need a simultaneous hghooks & TBPL push to prod. 

Other than bug 782237, the changes for both have already landed (and look good as far as we can tell), so we are keen to get this rolled out to prod as soon as possible (so that we don't have an accidental production push of one repo without the other & so it doesn't block any emergency TBPL pushes).

Once we have the good to go in this bug (ie bug 782237 is fixed & sheriffs ready), the process will be:

1) Update the hg hooks directory on hg.mozilla.org to:
   https://hg.mozilla.org/hgcustom/hghooks/rev/8db0fe2a5231

   Sync the repo working directory with the internal directory from where the hooks actually run (updated files should be: runtests.py, mozhghooks/treeclosure.py, mozhghooks/treeclosure_comm_central.py), per bug 751867 comment 6:

> On the hg servers we have working copy of our hg hooks.  Every time I get a
> bug like this I do an 'hg update', then copy the files over to the internal
> directory where the hooks actually run from.
> 
> I just need to know which files to backup/copy.

2) TBPL prod updated to:
   https://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/rev/a7b02d5b8785

3) Sheriff to close a tree (eg mozilla-inbound) using https://treestatus.mozilla.org/ & try pushing to make sure they are unable to. We should also test an approval required repo such as aurora/beta/esr10.

If we have any problems with the new tree closure hook, to rollback:

1) Revert hg hooks prod to:
   https://hg.mozilla.org/hgcustom/hghooks/rev/38218ddfda34

   ...and copy the same files as above back over the live copies.

2) Revert TBPL prod to:
   https://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/rev/f69518fcd13b

Presuming everything works, I will:

1) Comment in the sheriffpass bug as a final reminder.
2) Post an announcement to dev.platform.
3) Change the old tinderbox status message box to say something like "Not used, please see https://treestatus.mozilla.org/", in case people end up there out of habit.
(Reporter)

Updated

6 years ago
Whiteboard: [waiting on bug 782237's push to production]
(Reporter)

Comment 1

6 years ago
I've updated https://treestatus.mozilla.org/ with the current tree statuses/messages from Tinderbox.

The no-caching fix has also now been deployed to treestatus prod (bug 782237), so think we are ready to proceed :-)
Whiteboard: [waiting on bug 782237's push to production]
Assignee: server-ops-devservices → bkero
(Reporter)

Comment 2

6 years ago
Ben, I don't suppose you'd be able to take a look at this today?

We now have a queue of 4 (soon to be 5) other landings on the TBPL repo that can't be pushed live until this has been done.

Cheers :-)
(Assignee)

Comment 3

6 years ago
Hg hooks were updated.  Here's the output of the tbpl update:

[root@genericadm.private.phx1 ~]# /data/genericrhel6/src/tbpl.mozilla.org/update a7b02d5b8785
+ date
Tue Aug 21 10:39:40 PDT 2012
+ echo -e 'Updating code...'
Updating code...
+ cd /data/genericrhel6/src/tbpl.mozilla.org/tbpl
+ hg pull
pulling from http://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog
searching for changes
adding changesets
adding manifests
adding file changes
added 4 changesets with 6 changes to 5 files
(run 'hg update' to get a working copy)
+ hg update a7b02d5b8785
7 files updated, 0 files merged, 0 files removed, 0 files unresolved
+ checkretval
+ retval=0
+ [[ 0 -gt 0 ]]
+ cd /data/genericrhel6/src/tbpl.mozilla.org/tbpl
+ hg parent
changeset:   831:a7b02d5b8785
user:        Matt Brubeck <mbrubeck@mozilla.com>
date:        Thu Aug 09 13:44:19 2012 -0700
summary:     Bug 741775 -  Try pushes to non-default branches don't show builds [r=philor]

+ checkretval
+ retval=0
+ [[ 0 -gt 0 ]]
+ /data/genericrhel6/deploy -n tbpl.mozilla.org
[2012-08-21 10:39:41] Running rsync_project
[2012-08-21 10:39:41] [localhost] running: /usr/bin/rsync -aq --include '.gitkeep' --exclude '.git*' --exclude '.hg*' --exclude '.svn*' --exclude 'CVS' --delete /data/genericrhel6/src/tbpl.mozilla.org/ /data/genericrhel6/www/tbpl.mozilla.org/
[2012-08-21 10:39:41] [localhost] finished: /usr/bin/rsync -aq --include '.gitkeep' --exclude '.git*' --exclude '.hg*' --exclude '.svn*' --exclude 'CVS' --delete /data/genericrhel6/src/tbpl.mozilla.org/ /data/genericrhel6/www/tbpl.mozilla.org/ (0.050s)
[2012-08-21 10:39:41] Finished rsync_project (0.050s)
[2012-08-21 10:39:41] Running commit_www
[2012-08-21 10:39:41] [localhost] running: cd /data/genericrhel6/www && /usr/bin/git add .; /usr/bin/git commit -a -m 'deploy ['tbpl.mozilla.org']'
[2012-08-21 10:39:46] [localhost] finished: cd /data/genericrhel6/www && /usr/bin/git add .; /usr/bin/git commit -a -m 'deploy ['tbpl.mozilla.org']' (5.107s)
[localhost] out: [master eb8d60e] deploy [tbpl.mozilla.org]
[localhost] out: 7 files changed, 65 insertions(+), 40 deletions(-)
[2012-08-21 10:39:46] Finished commit_www (5.107s)
Status: NEW → ASSIGNED
(Reporter)

Comment 4

6 years ago
Tested:

That TBPL is using the new statuses at treestatus.mozilla.org (wording is intentionally slightly different):
-> PASS

Closed inbound using treestatus.mozilla.org & pushed a dummy commit without the CLOSED TREE string:
-> Push blocked, so PASS.

Pushed a dummy commit without the a=foo string to aurora:
-> Push blocked, so PASS.

Asked someone in #developers to push to inbound when it was OPEN:
-> Push allowed, so PASS.

Looks all good - thank you Ben :-D

Before we can close this bug, I just need to:

> 1) Comment in the sheriffpass bug as a final reminder.
> 2) Post an announcement to dev.platform.
> 3) Change the old tinderbox status message box to say something like "Not
> used, please see https://treestatus.mozilla.org/", in case people end up
> there out of habit.
(Reporter)

Comment 5

6 years ago
> > 3) Change the old tinderbox status message box to say something like "Not
> > used, please see https://treestatus.mozilla.org/", in case people end up
> > there out of habit.

Done.

Added:
"No longer used by the hg tree closure hook / TBPL, as of bug 782239. Please go to: 
https://treestatus.mozilla.org/"

Note: Not all trees have the tree-closure hook set up (see bug 758994 for the list). Switching to treestatus hasn't regressed us, this was pre-existing (and I will file bugs to get hooks added over the next few days).
(Reporter)

Comment 6

6 years ago
> 1) Comment in the sheriffpass bug as a final reminder.
https://bugzilla.mozilla.org/show_bug.cgi?id=322423#c71

> 2) Post an announcement to dev.platform.
https://groups.google.com/d/msg/mozilla.dev.platform/z4KPzg-j-YI/o73sy-EmCC8J

I've also updated:
* https://wiki.mozilla.org/Release_Management/Merge_Documentation#Close_the_Trees
* https://wiki.mozilla.org/ReleaseEngineering/How_To/Close_or_Open_the_Tree
* https://wiki.mozilla.org/Tree_Closures
* https://wiki.mozilla.org/Sheriff_Duty

(Several of those pages are pretty ancient/crufty, have made a note to give them a bit of an overhaul at a later date)

All done here :-)
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Component: Server Operations: Developer Services → General
Product: mozilla.org → Developer Services
You need to log in before you can comment on or make changes to this bug.