782243 - dtd style localization note in a properties file causes errors with l10n tools

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect)

Description

[Pascal Chevrel:pascalc]

I was looking at strange errors in Transvision (a glossaire tool for localizers based on th silme library for string extraction) and it seems that a specific file among seamonkey files is the cause of it:

https://hg.mozilla.org/comm-central/file/0a8dcf82693c/suite/debugQA/locales/en-US/debugQANavigatorOverlay.properties

The file is using an XML style comment as a localization note into a properties file used by Javascript (https://developer.mozilla.org/en-US/docs/Localization_notes)

This is causing the silme library to generate wrong output.

I also notice that no team translated this string and there is no error in dashboards, so my guess is that compare-locales also ignores it.

The comment should be updated to use proper syntax.

This is probably not filed in the right component as I couldn't find a component that would fit that case.

Comment 1

[Philip Chee]

Bug 381343 - Move SeaMonkey's debug/QA UI elements to be built as an extension in-tree
r+/sr+=Neil

Comment 2

[[e-mail]]

The string got moved from a .dtd to a .properties file in attachment 274268 [details] [diff] [review] ;-)

Comment 3

[Pascal Chevrel:pascalc]

Could you guys fix that comment on trunk and current branches of comm-central? If not, I need to know so as to find an alternative solution to prevent corrupt data in the TMX files we generate for localizers. Thanks

Comment 4

[Robert Kaiser]

FYI, suite/debugQA is supposed to not be localized anyhow, and any L10n of it won't get packaged anywhere. You probably should just exclude it from the TMX stuff.

That said, you detected a valid bug there. ;-)

Comment 5

[Edmund Wong (:ewong)]

Attachment: Changed comment style. (v1)

Comment 6

[Edmund Wong (:ewong)]

Pushed to comm-central:
http://hg.mozilla.org/comm-central/rev/e7271c5607e9