dtd style localization note in a properties file causes errors with l10n tools

RESOLVED FIXED in seamonkey2.17

Status

SeaMonkey
Build Config
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: pascalc, Assigned: ewong)

Tracking

Trunk
seamonkey2.17

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good first bug][lang=L10n/properties][mentor=KaiRo][level=easy], URL)

Attachments

(1 attachment)

I was looking at strange errors in Transvision (a glossaire tool for localizers based on th silme library for string extraction) and it seems that a specific file among seamonkey files is the cause of it:

https://hg.mozilla.org/comm-central/file/0a8dcf82693c/suite/debugQA/locales/en-US/debugQANavigatorOverlay.properties

The file is using an XML style comment as a localization note into a properties file used by Javascript (https://developer.mozilla.org/en-US/docs/Localization_notes)

This is causing the silme library to generate wrong output.

I also notice that no team translated this string and there is no error in dashboards, so my guess is that compare-locales also ignores it.

The comment should be updated to use proper syntax.

This is probably not filed in the right component as I couldn't find a component that would fit that case.
Assignee: nobody → bugspam.Callek

Comment 1

5 years ago
Bug 381343 - Move SeaMonkey's debug/QA UI elements to be built as an extension in-tree
r+/sr+=Neil
Blocks: 381343

Comment 2

5 years ago
The string got moved from a .dtd to a .properties file in attachment 274268 [details] [diff] [review] ;-)
Could you guys fix that comment on trunk and current branches of comm-central? If not, I need to know so as to find an alternative solution to prevent corrupt data in the TMX files we generate for localizers. Thanks

Comment 4

5 years ago
FYI, suite/debugQA is supposed to not be localized anyhow, and any L10n of it won't get packaged anywhere. You probably should just exclude it from the TMX stuff.

That said, you detected a valid bug there. ;-)

Updated

5 years ago
Whiteboard: [good first bug][lang=L10n/properties][mentor=KaiRo][level=easy]

Updated

5 years ago

Updated

5 years ago
Assignee: bugspam.Callek → nobody
(Assignee)

Comment 5

5 years ago
Created attachment 693800 [details] [diff] [review]
Changed comment style. (v1)
Assignee: nobody → ewong
Status: NEW → UNCONFIRMED
Ever confirmed: false
Attachment #693800 - Flags: review?(neil)
(Assignee)

Updated

5 years ago
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true

Updated

5 years ago
Attachment #693800 - Flags: review?(neil) → review+
(Assignee)

Comment 6

5 years ago
Pushed to comm-central:
http://hg.mozilla.org/comm-central/rev/e7271c5607e9
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED

Updated

5 years ago
Target Milestone: --- → seamonkey2.17
You need to log in before you can comment on or make changes to this bug.