Closed Bug 78229 Opened 24 years ago Closed 4 years ago

meta charset does not work when autodection find first

Categories

(Core :: Internationalization, defect)

Product:
Core
Component:
Internationalization
Platform:
x86
Windows NT
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.0.1

People

(Reporter: shanjian, Assigned: jshin1987)

References

(
URL
)

Details

(Keywords: intl)

Attachments

(3 files)

new proposed fix
795 bytes, patch
Details | Diff | Splinter Review
A new patch.
1.29 KB, patch
Details | Diff | Splinter Review
new and complete patch
2.28 KB, patch
Details | Diff | Splinter Review
reproducible steps: 1, Go to above URL, the page is loaded correctly. 2, Set autodection to East Asian The page will be reload incorrectly 3, Reload\ Now it is correct again 4, Reload Now it is incorrect again
The problem is because autodection find the charset first, though it is not correct. (That has been filed in bug 72074). Meta tag observer later notify webshell its finding, but because "mCharsetReloadState" is set to "eCharsetReloadRequested", reload is not happening.
Summary: meta charset does not work when autodection find first → meta charset does not work when autodection find first
Target Milestone: --- → mozilla0.9.1
Attached patch new proposed fix — — Splinter Review
Status: UNCONFIRMED → NEW
Ever confirmed: true
QA Contact: andreasb → ylong
Keywords: intl
r=ftang
shanjian- please ask for sr
Whiteboard: patch reviwed. need sr
Chris, can you sr this one. Let me know if I should ask someone else. thx.
Status: NEW → ASSIGNED
add attinasi@netscape.com to cc list
sr=attinasi
Whiteboard: patch reviwed. need sr → ready to checkin
fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Verified as fixed in 2001-05-24-06 Win32, 5-24-08 Mac, and 5-22-13 Linux build.
Verified.
Status: RESOLVED → VERIFIED
This fix caused serious regression in bug 87413. This one need to be reopened. Fix need to be backed out.
Status: VERIFIED → REOPENED
Resolution: FIXED → ---
Attached patch A new patch. — — Splinter Review
The previous patch seems caused a serie of regression. This new patch should be Ok to fix the problem without such side-effect. If we can do reload, we should not modify charset and charset source. In next reload, same notification might appears again and we will got a new reload request. Since this will happen rarely, performance decrease is ignorable.
Status: REOPENED → ASSIGNED
set milestone to mozilla 1.0
Whiteboard: ready to checkin → patch available
Target Milestone: mozilla0.9.1 → mozilla1.0
Previous fix is incomplete. Complete one will follow.
Whiteboard: patch available → patch available, need r/sr
frank, can you review this one?
*** Bug 92856 has been marked as a duplicate of this bug. ***
*** Bug 92856 has been marked as a duplicate of this bug. ***
The patch I proposed at least does not work for another testcase, www.netscape.fr. A new patch need to be worked on.
Whiteboard: patch available, need r/sr
Target Milestone: mozilla1.0 → mozilla1.0.1
shanjian is no longer working on mozilla for 2 years and these bugs are still here. Mark them won't fix. If you want to reopen it, find a good owner first.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago → 20 years ago
Resolution: --- → WONTFIX
Mass Reassign Please excuse the spam
Assignee: shanjian → nobody
Mass Re-opening Bugs Frank Tang Closed on Wensday March 02 for no reason, all the spam is his fault feel free to tar and feather him
Status: RESOLVED → REOPENED
Resolution: WONTFIX → ---
Reassigning Franks old bugs to Jungshik Shin for triage - Sorry for spam
Assignee: nobody → jshin1987
Status: REOPENED → NEW
QA Contact: amyy → i18n
Status: NEW → RESOLVED
Closed: 20 years ago → 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: