782315 - GC: Cut out unnecessary work when not collecting atoms

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jon Coppeard (:jonco)]

Attachment: Proposed fix

At the moment, if atoms are not being collected then every atom is marked in the mark phase so that no atoms will be collected in sweep phase.  It's more efficient to neither mark nor sweep the atoms in this case.

Also, we can simplify things by setting the collecting flag of the atoms compartment to record whether atoms are being swept at the start of collection.

Comment 1

[Jon Coppeard (:jonco)]

Attachment: Proposed fix

Comment 2

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 651432 [details] [diff] [review]
Proposed fix

Review of attachment 651432 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jsgc.cpp
@@ +3507,1 @@
>      {

Brace should be on the same line as the if.

Comment 3

[Jon Coppeard (:jonco)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/13d2ad44ba74

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/13d2ad44ba74