Note: There are a few cases of duplicates in user autocompletion which are being worked on.

[AccessFu] appinfo.OS == 'Android' does not always mean Android

RESOLVED FIXED in mozilla17

Status

()

Core
Disability Access APIs
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: eeejay, Assigned: eeejay)

Tracking

Trunk
mozilla17
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Apparently, B2G will also report its OS to be Android, so we should use the build app name instead, 'mobile/android'.
(Assignee)

Comment 1

5 years ago
Created attachment 651439 [details] [diff] [review]
Change platform conditionals for Android Firefox to "mobile/android".
Attachment #651439 - Flags: review?(dbolter)
Comment on attachment 651439 [details] [diff] [review]
Change platform conditionals for Android Firefox to "mobile/android".

Review of attachment 651439 [details] [diff] [review]:
-----------------------------------------------------------------

r=me. Do you know specifically why b2g chooses to report Android?
Attachment #651439 - Flags: review?(dbolter) → review+
(Assignee)

Comment 3

5 years ago
(In reply to David Bolter [:davidb] from comment #2)
> Comment on attachment 651439 [details] [diff] [review]
> Change platform conditionals for Android Firefox to "mobile/android".
> 
> Review of attachment 651439 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> r=me. Do you know specifically why b2g chooses to report Android?

No, I bet it will eventually be "Gonk", but I think the changes here make sense anyway.
What about this conditional - is it okay to keep using 'Android' here?

if (Utils.OS != 'Android' && !aEvent.shiftKey)
(Assignee)

Comment 5

5 years ago
(In reply to David Bolter [:davidb] from comment #4)
> What about this conditional - is it okay to keep using 'Android' here?
> 
> if (Utils.OS != 'Android' && !aEvent.shiftKey)

I think so, since that distinguishes device from desktop testing. BTW, I am doing a gesture rework, so that will end up somewhere else soon anyway.

Updated

5 years ago
Assignee: nobody → eitan
(Assignee)

Comment 6

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/e0876ea69295

Comment 7

5 years ago
https://hg.mozilla.org/mozilla-central/rev/e0876ea69295
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in before you can comment on or make changes to this bug.