Closed
Bug 782317
Opened 12 years ago
Closed 12 years ago
[AccessFu] appinfo.OS == 'Android' does not always mean Android
Categories
(Core :: Disability Access APIs, defect)
Core
Disability Access APIs
Tracking
()
RESOLVED
FIXED
mozilla17
People
(Reporter: eeejay, Assigned: eeejay)
Details
Attachments
(1 file)
|
2.66 KB,
patch
|
davidb
:
review+
|
Details | Diff | Splinter Review |
Apparently, B2G will also report its OS to be Android, so we should use the build app name instead, 'mobile/android'.
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #651439 -
Flags: review?(dbolter)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 651439 [details] [diff] [review]
Change platform conditionals for Android Firefox to "mobile/android".
Review of attachment 651439 [details] [diff] [review]:
-----------------------------------------------------------------
r=me. Do you know specifically why b2g chooses to report Android?
Attachment #651439 -
Flags: review?(dbolter) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
(In reply to David Bolter [:davidb] from comment #2)
> Comment on attachment 651439 [details] [diff] [review]
> Change platform conditionals for Android Firefox to "mobile/android".
>
> Review of attachment 651439 [details] [diff] [review]:
> -----------------------------------------------------------------
>
> r=me. Do you know specifically why b2g chooses to report Android?
No, I bet it will eventually be "Gonk", but I think the changes here make sense anyway.
|
|
||
Comment 4•12 years ago
|
||
What about this conditional - is it okay to keep using 'Android' here?
if (Utils.OS != 'Android' && !aEvent.shiftKey)
|
|
Assignee | |
Comment 5•12 years ago
|
||
(In reply to David Bolter [:davidb] from comment #4)
> What about this conditional - is it okay to keep using 'Android' here?
>
> if (Utils.OS != 'Android' && !aEvent.shiftKey)
I think so, since that distinguishes device from desktop testing. BTW, I am doing a gesture rework, so that will end up somewhere else soon anyway.
|
|
||
Updated•12 years ago
|
Assignee: nobody → eitan
|
|
Assignee | |
Comment 6•12 years ago
|
||
|
||
Comment 7•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in
before you can comment on or make changes to this bug.
Description
•