782324 - Add support in JarMaker for file names that contain '@'

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Steven Michaud [:smichaud] (Retired)]

I frankly don't know if this worth fixing, but it came up at bug 781327 comment #6.

The build error is as follows:

	  /usr/local/src/Mozilla/bugzilla781327/mozilla-central/toolkit/themes/pinstripe/global/jar.mn
processing /usr/local/src/Mozilla/bugzilla781327/mozilla-central/toolkit/themes/pinstripe/global/jar.mn
Traceback (most recent call last):
  File "/usr/local/src/Mozilla/bugzilla781327/mozilla-central/config/JarMaker.py", line 489, in <module>
    main()
  File "/usr/local/src/Mozilla/bugzilla781327/mozilla-central/config/JarMaker.py", line 486, in main
    localedirs=options.l10n_src)
  File "/usr/local/src/Mozilla/bugzilla781327/mozilla-central/config/JarMaker.py", line 265, in makeJars
    jardir=jardir)
  File "/usr/local/src/Mozilla/bugzilla781327/mozilla-central/config/JarMaker.py", line 204, in makeJar
    raise RuntimeError(l)
RuntimeError:   skin/classic/global/tree/[e-mail]                             (tree/[e-mail])

This error is only visible if you set MOZ_MAKE_FLAGS to "-j1" in your mozconfig file.

The error goes away if you replace the '@' character with a '-' character.  Which is why I assume the '@' character is the problem.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

<gavin> anyone have any thoughts about bug 782324?
<khuey> my first thought is "is '@' even a legal filesystem character on our tier 1 platforms?"
<khuey> my second thought is that you probably just need to fiddle the regexes JarMaker.py uses
<gps> khuey: it's a valid character on OS X and Windows
<khuey> even on FAT?
<gavin> surely those are the most restrictive?
<gps> I assume valid on Linux as well. but it is a shell metacharacter, so suckiness
<gps> I don't have a FAT filesystem available to test on
<khuey> the internet seems to think it's allowed on FAT

Comment 2

[Frank Yan (:fryn)]

Attachment: patch

We'd like to have this for bug 781327, so we can follow the naming convention for HiDPI image files on OS X.

Comment 3

[Frank Yan (:fryn)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/24d7f059eed2

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/24d7f059eed2