782351 - Device Storage - Expose sdcard/volume state flag on stat result

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Comment 1

[Doug Turner (:dougt)]

Attachment: patch v.1

Comment 2

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 651476 [details] [diff] [review]
patch v.1

Review of attachment 651476 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/interfaces/devicestorage/nsIDOMDeviceStorageStat.idl
@@ +9,5 @@
>  {
>    readonly attribute PRUint64 totalBytes;
>    readonly attribute PRUint64 freeBytes;
> +
> +  // shared, available, unavailable

I'd put quotes around these for clarity.

Comment 3

[Doug Turner (:dougt)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8c4e3f8254b4

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/8c4e3f8254b4

Comment 5

[David Flanagan [:djf]]

This is not working for me in the Gallery app.

If /sdcard is in the "shared" or "unavailable" state, then calling stat() never returns a result to onsuccess.

Instead, onerror is called with request.error.name set to:

  Unknown file path = /sdcard/DCIM path = 

It looks to me like the only time stat() works is when the card is already in the available state.

This was tested on the otoro with the Gallery app temporarily blacklisted.  Haven't tested it OOP.

Comment 6

[David Flanagan [:djf]]

Testing it OOP shows the same behavior except that the stat error us truncated to "Unknown"

Comment 7

[David Flanagan [:djf]]

I've landed a change to the Gaia app to track this change.  If you use the latest Gallery app, you can confirm that the onerror() handler of the stat() request is being called if there is no sdcard or if it is mouned for UMS.

Comment 8

[Doug Turner (:dougt)]

Attachment: patch v.1 followup

Comment 9

[Doug Turner (:dougt)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/57c7f49b37b3

Comment 10

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/57c7f49b37b3

Comment 11

[David Flanagan [:djf]]

I've reopened this because it is not working for OOP processes.

Gallery is now OOP. If I call stat with no card or during USB Mass Storage, the onerror handler on the stat request is triggered.  

But screenshots are in process as part of the system app.  And they get correct results when calling stat() in either of those two conditions.

Comment 12

[Doug Turner (:dougt)]

Attachment: patch v.1 - followup - followup

missed a place

Comment 13

[Doug Turner (:dougt)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/59f82234c8d9

Comment 14

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/59f82234c8d9