782373 - use HISTOGRAM_BOOLEAN more consistently

Status: RESOLVED FIXED

(Toolkit :: Telemetry, defect)

Description

[Nathan Froyd [:froydnj]]

We should use HISTOGRAM_BOOLEAN everywhere possible, for consistency and avoiding stupid errors.

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: patch

The obvious patch that you'd expect.  CACHE_LM_INCONSISTENT doesn't get changed here because there's an outstanding patch in bug 781200 for doing that one.

Comment 2

[(dormant account)]

Comment on attachment 651495 [details] [diff] [review]
patch

Shoudn't we ban non-boolean histograms of size 2 while at it?

Comment 3

[Nathan Froyd [:froydnj]]

Comment on attachment 651495 [details] [diff] [review]
patch

(In reply to Taras Glek (:taras) from comment #2)
> Shoudn't we ban non-boolean histograms of size 2 while at it?

We already do:

http://mxr.mozilla.org/mozilla-central/source/toolkit/components/telemetry/Telemetry.cpp#197

Comment 4

[(dormant account)]

Then how does the code your changing compile?

Comment 5

[Nathan Froyd [:froydnj]]

(In reply to Taras Glek (:taras) from comment #4)
> Then how does the code your changing compile?

I don't understand why you think it wouldn't.

Comment 6

[(dormant account)]

(In reply to Nathan Froyd (:froydnj) from comment #5)
> (In reply to Taras Glek (:taras) from comment #4)
> > Then how does the code your changing compile?
> 
> I don't understand why you think it wouldn't.

Sorry I'm tired, missing obvious things. Nevermind my ask to make things not compile since that will be obsoleted by json equiv of telemetryhistograms.h file in near future.
I was thinking that we should ban declaring boolean histograms with 'HISTOGRAM(' to keep TelemetryHistograms.h consistent until the end of time...but since end of .h time is near...

Comment 7

[Nathan Froyd [:froydnj]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/14c44cb256a7

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/14c44cb256a7