Closed Bug 782391 Opened 9 years ago Closed 9 years ago

device storage - Watch should also go through the permission prompt.

Categories

(Core :: DOM: Device Interfaces, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla17

People

(Reporter: dougt, Assigned: dougt)

Details

Attachments

(1 file)

We were not checking to the result of Allow().  Instead, we always sent back watch state changes.
Attached patch patch v.1Splinter Review
Assignee: nobody → doug.turner
Attachment #651509 - Flags: review?(jonas)
Comment on attachment 651509 [details] [diff] [review]
patch v.1

Review of attachment 651509 [details] [diff] [review]:
-----------------------------------------------------------------

Shouldn't we also trigger the prompt when someone registers as an event listener?
yup, that happens now in nsDOMDeviceStorage::AddEventListener().  The problem was we'd prompt and never care about what the result was -- we'd just went ahead and send the change event to all listeners.
Comment on attachment 651509 [details] [diff] [review]
patch v.1

Review of attachment 651509 [details] [diff] [review]:
-----------------------------------------------------------------

Ok. Please make sure that the prompt also happens when the onchange property is set, rather than when addEventListener is called.
Attachment #651509 - Flags: review?(jonas) → review+
https://hg.mozilla.org/mozilla-central/rev/13efbdf35a8b
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in before you can comment on or make changes to this bug.