device storage - Watch should also go through the permission prompt.

RESOLVED FIXED in mozilla17

Status

()

Core
DOM: Device Interfaces
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: dougt, Assigned: dougt)

Tracking

unspecified
mozilla17
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
We were not checking to the result of Allow().  Instead, we always sent back watch state changes.
(Assignee)

Comment 1

5 years ago
Created attachment 651509 [details] [diff] [review]
patch v.1
Assignee: nobody → doug.turner
Attachment #651509 - Flags: review?(jonas)
Comment on attachment 651509 [details] [diff] [review]
patch v.1

Review of attachment 651509 [details] [diff] [review]:
-----------------------------------------------------------------

Shouldn't we also trigger the prompt when someone registers as an event listener?
(Assignee)

Comment 3

5 years ago
yup, that happens now in nsDOMDeviceStorage::AddEventListener().  The problem was we'd prompt and never care about what the result was -- we'd just went ahead and send the change event to all listeners.
Comment on attachment 651509 [details] [diff] [review]
patch v.1

Review of attachment 651509 [details] [diff] [review]:
-----------------------------------------------------------------

Ok. Please make sure that the prompt also happens when the onchange property is set, rather than when addEventListener is called.
Attachment #651509 - Flags: review?(jonas) → review+
(Assignee)

Comment 5

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/13efbdf35a8b
https://hg.mozilla.org/mozilla-central/rev/13efbdf35a8b
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
Tabs :(
You need to log in before you can comment on or make changes to this bug.