782391 - device storage - Watch should also go through the permission prompt.

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Doug Turner (:dougt)]

We were not checking to the result of Allow().  Instead, we always sent back watch state changes.

Comment 1

[Doug Turner (:dougt)]

Attachment: patch v.1

Comment 2

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 651509 [details] [diff] [review]
patch v.1

Review of attachment 651509 [details] [diff] [review]:
-----------------------------------------------------------------

Shouldn't we also trigger the prompt when someone registers as an event listener?

Comment 3

[Doug Turner (:dougt)]

yup, that happens now in nsDOMDeviceStorage::AddEventListener().  The problem was we'd prompt and never care about what the result was -- we'd just went ahead and send the change event to all listeners.

Comment 4

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 651509 [details] [diff] [review]
patch v.1

Review of attachment 651509 [details] [diff] [review]:
-----------------------------------------------------------------

Ok. Please make sure that the prompt also happens when the onchange property is set, rather than when addEventListener is called.

Comment 5

[Doug Turner (:dougt)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/13efbdf35a8b

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/13efbdf35a8b

Comment 7

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Tabs :(