Closed Bug 782408 Opened 10 years ago Closed 9 years ago

Make nrappkit compile use NSPR integral types

Categories

(Core :: WebRTC: Networking, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla18

People

(Reporter: ekr, Assigned: ekr)

Details

(Whiteboard: [WebRTC], [blocking-webrtc-] [qa-])

Attachments

(1 file, 1 obsolete file)

Currently this defaults to some obvious integral types. This involves just modifying r_types.h and everyhting else should fall into line.
Assignee: nobody → ekr
Whiteboard: [WebRTC], [blocking-webrtc-]
Comment on attachment 668922 [details] [diff] [review]
Update nrappkit to use stddint types;

Review of attachment 668922 [details] [diff] [review]:
-----------------------------------------------------------------

https://tbpl.mozilla.org/?tree=Try&rev=f0aacdfbf824
Attachment #668922 - Flags: review?(rjesup)
Comment on attachment 668922 [details] [diff] [review]
Update nrappkit to use stddint types;

Review of attachment 668922 [details] [diff] [review]:
-----------------------------------------------------------------

::: media/mtransport/objs.mk
@@ +49,5 @@
>  
> +DEFINES += \
> +   -DR_DEFINED_INT2=int16_t -DR_DEFINED_UINT2=uint16_t \
> +   -DR_DEFINED_INT4=int32_t -DR_DEFINED_UINT4=uint32_t \
> +   -DR_DEFINED_INT8=int64_t -DR_DEFINED_UINT8=uint64_t

Missing \ at the end

::: media/mtransport/third_party/nrappkit/src/util/libekr/r_types.h
@@ +83,5 @@
>  
>  #ifndef _r_types_h
>  #define _r_types_h
>  
> +#include <stdint.h>

Can't assume it exists.  surround with #ifdef HAVE_STDINT_H, or see other examples in the tree like media/webrtc/signaling/src/sipcc/cpr/win32/cpr_win_types.h
Attachment #668922 - Flags: review?(rjesup) → review-
Attachment #668922 - Attachment is obsolete: true
Attachment #668927 - Flags: review?(rjesup)
Attachment #668927 - Flags: review?(rjesup) → review+
Attachment #668927 - Flags: checkin?(rjesup)
https://hg.mozilla.org/mozilla-central/rev/386f6fb98537
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
Whiteboard: [WebRTC], [blocking-webrtc-] → [WebRTC], [blocking-webrtc-] [qa-]
Attachment #668927 - Flags: checkin?(rjesup)
You need to log in before you can comment on or make changes to this bug.