782408 - Make nrappkit compile use NSPR integral types

Status: RESOLVED FIXED

(Core :: WebRTC: Networking, defect)

Description

[Eric Rescorla (:ekr)]

Currently this defaults to some obvious integral types. This involves just modifying r_types.h and everyhting else should fall into line.

Comment 1

[Eric Rescorla (:ekr)]

Attachment: Update nrappkit to use stddint types;

Comment 2

[Eric Rescorla (:ekr)]

Comment on attachment 668922 [details] [diff] [review]
Update nrappkit to use stddint types;

Review of attachment 668922 [details] [diff] [review]:
-----------------------------------------------------------------

https://tbpl.mozilla.org/?tree=Try&rev=f0aacdfbf824

Comment 3

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 668922 [details] [diff] [review]
Update nrappkit to use stddint types;

Review of attachment 668922 [details] [diff] [review]:
-----------------------------------------------------------------

::: media/mtransport/objs.mk
@@ +49,5 @@
>  
> +DEFINES += \
> +   -DR_DEFINED_INT2=int16_t -DR_DEFINED_UINT2=uint16_t \
> +   -DR_DEFINED_INT4=int32_t -DR_DEFINED_UINT4=uint32_t \
> +   -DR_DEFINED_INT8=int64_t -DR_DEFINED_UINT8=uint64_t

Missing \ at the end

::: media/mtransport/third_party/nrappkit/src/util/libekr/r_types.h
@@ +83,5 @@
>  
>  #ifndef _r_types_h
>  #define _r_types_h
>  
> +#include <stdint.h>

Can't assume it exists.  surround with #ifdef HAVE_STDINT_H, or see other examples in the tree like media/webrtc/signaling/src/sipcc/cpr/win32/cpr_win_types.h

Comment 4

[Eric Rescorla (:ekr)]

Attachment: Update nrappkit to use stddint types;

Comment 5

[Eric Rescorla (:ekr)]

https://tbpl.mozilla.org/?tree=Try&rev=c6ab7e805546

Comment 6

[Randell Jesup [:jesup] (needinfo me)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/386f6fb98537

Comment 7

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/386f6fb98537